Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] Qt5 Webkit fails to compile
Date: Sun, 02 Feb 2020 22:26:00 +0100	[thread overview]
Message-ID: <87o8ugn0k7.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200202194245.46e18d8e@gmx.net> (Peter Seiderer's message of "Sun, 2 Feb 2020 19:42:45 +0100")

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Hello Andrea,
 > On Sun, 2 Feb 2020 18:25:14 +0100, Andrea Simeoni <andreasimeoni73@gmail.com> wrote:

 >> Hi! I'm building a slightly modified config for Raspberry Pi 3 (attached
 >> the .config file).
 >> The compilation of qt5webkit fails. This is the error:
 >> 
 >> platform/graphics/SegmentedFontData.cpp:65:9: error: expected ?;? before
 >> ?if?
 >> if (!containsCharacter(c))
 >> ^~
 >> 
 >> the line before is:
 >> 
 >> U16_NEXT(characters, i, length, c)
 >> 
 >> and U16_NEXT is defined in uft16.h as:
 >> 
 >> #define U16_NEXT(s, i, length, c) { \
 >> (c)=(s)[(i)++]; \
 >> if(U16_IS_LEAD(c)) { \
 >> uint16_t __c2; \
 >> if((i)<(length) && U16_IS_TRAIL(__c2=(s)[(i)])) { \
 >> ++(i); \
 >> (c)=U16_GET_SUPPLEMENTARY((c), __c2); \
 >> } \
 >> } \
 >> }
 >> 
 >> Is there something other I need to add in the configuration?

 > Detected the same failure while preparing the the Qt-5.12.7 version bump,
 > fixed by the following qt5webkit patch (proper buildroot patch will
 > follow soon):

 > diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
 > index af63b141..26f7312b 100644
 > --- a/Source/WebCore/dom/Document.cpp
 > +++ b/Source/WebCore/dom/Document.cpp
 > @@ -3846,12 +3846,12 @@ static bool isValidNameNonASCII(const UChar* characters, unsigned length)
 >      unsigned i = 0;
 
 >      UChar32 c;
 > -    U16_NEXT(characters, i, length, c)
 > +    U16_NEXT(characters, i, length, c);
 >      if (!isValidNameStart(c))
 >          return false;
 
 >      while (i < length) {
 > -        U16_NEXT(characters, i, length, c)
 > +        U16_NEXT(characters, i, length, c);

This looks very similar to our recent webkitgtk / wpewebkit patches:

https://git.buildroot.net/buildroot/commit/?id=8f8abbeec33ce8dfc0e3b14d2c352210634ce28c

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2020-02-02 21:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02 17:25 [Buildroot] Qt5 Webkit fails to compile Andrea Simeoni
2020-02-02 18:42 ` Peter Seiderer
2020-02-02 19:51   ` Andrea Simeoni
2020-02-02 21:03     ` Peter Seiderer
2020-02-03 10:13       ` Andrea Simeoni
2020-02-03 14:13         ` Peter Seiderer
2020-02-06 16:52           ` Andrea Simeoni
2020-02-20  8:10           ` Peter Seiderer
2020-02-02 21:26   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8ugn0k7.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox