From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts/apply-patches: use "git apply" as a fallback when applying patches
Date: Wed, 23 Jan 2019 21:34:00 +0100 [thread overview]
Message-ID: <87o987jepz.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <55a5605d-5773-16d5-ef79-a37dac3c009a@mind.be> (Arnout Vandecappelle's message of "Wed, 23 Jan 2019 15:17:55 +0100")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
>> With this patch a package selection change that works on the developer's
>> machine where git is installed, would fail on the production build
>> machine that is missing git. Is there a clear error message in case of
>> patch failure?
> I'm with Baruch here. The reason to have this feature is exactly to have the
> possibility to have patches that modify binaries or that modify symlinks. Thus,
> it becomes likely that someone will submit such a patch. It will work for the
> developer, and it will also work in the autobuilders since all of them have git
> installed (otherwise they wouldn't be able to clone the Buildroot repo). Thus,
> any such patch will go unnoticed.
I agree, that is not good.
> I don't think it hurts to force git as a dependency.
If we do that, should we then always use git apply instead of patch?
(and drop the patch dependency)
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-01-23 20:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 20:30 [Buildroot] [PATCH] support/scripts/apply-patches: use "git apply" as a fallback when applying patches Thomas Petazzoni
2019-01-11 3:35 ` Baruch Siach
2019-01-11 8:15 ` Thomas Petazzoni
2019-01-13 8:00 ` Baruch Siach
2019-01-23 14:17 ` Arnout Vandecappelle
2019-01-23 20:34 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o987jepz.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox