From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] domoticz: fix build with python and cmake <= 3.7
Date: Mon, 03 Dec 2018 23:05:09 +0100 [thread overview]
Message-ID: <87o9a22rmy.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181128235633.10449-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Thu, 29 Nov 2018 00:56:33 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> domoticz will fail to build with python and older cmake
> Indeed, find_package(PythonLibs 3.4) will not recognize python 3.7 until
> cmake 3.7 and the following commit:
> https://github.com/Kitware/CMake/commit/c31573b9641e0f1bc7a34149506db51f3494323b
> To fix this, add a call to find_package(PythonInterp). Indeed, if
> FindPythonInterp has already found the major and minor version, that
> version will be inserted between the user supplied versions and the
> stock version list since cmake in version 3.1 and
> https://github.com/Kitware/CMake/commit/3816cd2dc7a7cc220e4f1b1e87fee986545b9cb3
> Fixes:
> - http://autobuild.buildroot.org/results/8e82501a7b49da628ec026132ffca44c0c813040
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2018.08.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-12-03 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 23:56 [Buildroot] [PATCH 1/1] domoticz: fix build with python and cmake <= 3.7 Fabrice Fontaine
2018-11-29 15:57 ` Peter Korsgaard
2018-12-03 22:05 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9a22rmy.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox