From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/linknx: add optional dependency to libcurl again
Date: Wed, 27 Dec 2017 10:37:10 +0100 [thread overview]
Message-ID: <87o9mktsu1.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171201223852.736b8246@windsurf.lan> (Thomas Petazzoni's message of "Fri, 1 Dec 2017 22:38:52 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Hello,
> On Fri, 1 Dec 2017 20:05:23 +0100, Bernd Kuhls wrote:
>> https://git.buildroot.net/buildroot/commit/package/linknx?id=e1c9a2349006e657e76dff35706a774376921fb7
>> made libcurl a hard dependency to fix autoreconf.
>>
>> https://git.buildroot.net/buildroot/commit/package/linknx?id=b56083099f113817edc6811e2cdd820df1c80450
>> removed autoreconf but did not re-add libcurl as optional dependency by
>> mistakenly assuming that libcurl is needed only for autoreconf.
>>
>> Tested using this defconfig:
>>
>> BR2_TOOLCHAIN_BUILDROOT_CXX=y
>> BR2_PACKAGE_LIBCURL=y
>> BR2_PACKAGE_LINKNX=y
>>
>> Configure log of linknx without this patch
>>
>> checking for curl-config... /usr/bin/curl-config
>> checking for the version of libcurl... 7.52.1
>> checking for libcurl >= version 7.14.0... yes
>> checking whether libcurl is usable... no
>>
>> and with this patch
>>
>> checking for
>> curl-config... /home/buildroot/br4/output/host/i586-buildroot-linux-uclibc/sysroot/usr/bin/curl-config
>> checking for the version of libcurl... 7.57.0
>> checking for libcurl >= version 7.14.0... yes
>> checking whether libcurl is usable... yes
>> checking for curl_free... yes
>>
>> Inspired by the fli4l project
>> https://web.nettworks.org/repo/changelog/fli4l?cs=49347
>>
>> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>> ---
>> package/linknx/linknx.mk | 7 +++++++
>> 1 file changed, 7 insertions(+)
Committed to 2017.11.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2017-12-27 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 19:05 [Buildroot] [PATCH 1/1] package/linknx: add optional dependency to libcurl again Bernd Kuhls
2017-12-01 21:38 ` Thomas Petazzoni
2017-12-27 9:37 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9mktsu1.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox