Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] docs/website: cosmetic changes
Date: Mon, 30 Nov 2015 23:01:04 +0100	[thread overview]
Message-ID: <87oaebjgf3.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1448920481-21268-1-git-send-email-angelo.compagnucci@gmail.com> (Angelo Compagnucci's message of "Mon, 30 Nov 2015 22:54:41 +0100")

>>>>> "Angelo" == Angelo Compagnucci <angelo.compagnucci@gmail.com> writes:

 > * Resized too big icons in download and documentation
 >   pages

 > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
 > ---
 > Cheangelog:

 > v1 -> v2:
 > Rebase to the latest git version

 >  docs/website/css/main.css  |  15 ++-
 >  docs/website/docs.html     |  30 ++---
 >  docs/website/download.html | 330 ++++++++++++++++++++++-----------------------
 >  3 files changed, 189 insertions(+), 186 deletions(-)

 > diff --git a/docs/website/css/main.css b/docs/website/css/main.css
 > index db9c4c9..57009cf 100644
 > --- a/docs/website/css/main.css
 > +++ b/docs/website/css/main.css
 > @@ -207,16 +207,21 @@ i {
 >  .flip-container {
 >  	perspective: 1000;
 >  }
 > -	/* flip the pane when hovered */
 > -	.flip-container:hover .flipper, .flip-container.hover .flipper {
 > -		transform: rotateY(180deg);
 > -	}
 > +/* flip the pane when hovered */
 > +.flip-container:hover .flipper, .flip-container.hover .flipper {
 > +	transform: rotateY(180deg);
 > +}
 
 > -.flip-container, .front, .back {
 > +.flip-container, .flip-container .front, .flip-container .back {
 >  	width: 180px;
 >  	height: 180px;
 >  }
 
 > +.flip-container-small, .flip-container-small .front, .flip-container-small .back {
 > +	width: 120px;
 > +	height: 120px;
 > +}
 > +
 >  /* flip speed goes here */
 >  .flipper {
 >  	transition: 0.6s;
 > diff --git a/docs/website/docs.html b/docs/website/docs.html
 > index 9cee36d..23cc13f 100644
 > --- a/docs/website/docs.html
 > +++ b/docs/website/docs.html
 > @@ -13,59 +13,59 @@
 
 >        <div class="row mt centered">
 >  	<div class="col-sm-4">
 > -	  <div class="flip-container center-block" ontouchstart="this.classList.toggle('hover');">
 > +	  <div class="flip-container flip-container-small center-block" ontouchstart="this.classList.toggle('hover');">
 >  	    <div class="flipper">
 >  	      <div class="front">
 > -		<a href="/manual.html"><img src="images/browser.png" width="180" alt=""></a>
 > +		<a href="/manual.html"><img src="images/browser.png" width="120" alt=""></a>

I'm far from a web expert, but why are we telling the browser to
downscale these images?

file docs/website/images/browser.png
docs/website/images/browser.png: PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced

E.G. why don't we send a 180x180 (or 120x120) image in the first place?

Same for the other images.

> +++ b/docs/website/download.html
 > @@ -4,176 +4,174 @@
 >  <div class="row nh">
 >  <div class="col-lg-10 col-lg-offset-1 col-md-12 col-sm-12 col-xs-12">
 
 > -  <div class="panel panel-primary">

This diff is not very readable to me. Notice that I'm right now changing
download.html (to release 2015.11), so it would be good if you could
rebase (again!).

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2015-11-30 22:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 21:54 [Buildroot] [PATCH v2] docs/website: cosmetic changes Angelo Compagnucci
2015-11-30 22:01 ` Peter Korsgaard [this message]
2015-11-30 22:06   ` Angelo Compagnucci
2015-11-30 22:20     ` Arnout Vandecappelle
2015-11-30 22:43       ` Angelo Compagnucci
2015-11-30 23:06         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oaebjgf3.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox