Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] valgrind: build for the right MIPS ISA revision level
Date: Sat, 03 Oct 2015 15:27:45 +0200	[thread overview]
Message-ID: <87oagg6q0e.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1442874710-11595-1-git-send-email-Vincent.Riera@imgtec.com> (Vicente Olivert Riera's message of "Mon, 21 Sep 2015 23:31:50 +0100")

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > When Valgrind detects a 32-bit MIPS architecture, it forcibly adds
 > -march=mips32 to CFLAGS; when it detects a 64-bit MIPS architecture, it
 > forcibly adds -march=mips64. This causes Valgrind to be built always for
 > the first ISA revision level (R1), even when the user has configured
 > Buildroot for the second ISA revision level (R2).

 > Since R2 is backwards compatible with R1, you can run a Valgrind built
 > for R1 in an R2 core. This is why nobody noticed about this problem, or
 > at least nobody complained.

 > But, since (I hope) we will support R6 in Buildroot in the near future,
 > this problem will become very important because R6 is not backwards
 > compatible with R1 or R2, so building Valgrind for R1 when your target
 > is R6 will result in a non-working Valgrind.

 > Override the CFLAGS variable (which Valgrind appends to its CFLAGS) and
 > pass the right -march option, so they take precedence over Valgrind's
 > wrongfully detected value.

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
 > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > ---
 > Changes v1 -> v2:
 >   - Improved commit log. (Suggested by Yann E. Morin)

Committed, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2015-10-03 13:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 22:31 [Buildroot] [PATCHv2] valgrind: build for the right MIPS ISA revision level Vicente Olivert Riera
2015-09-21 22:34 ` Yann E. MORIN
2015-10-03 13:27 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oagg6q0e.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox