From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] dropwatch: new package
Date: Mon, 22 Jul 2013 08:55:51 +0200 [thread overview]
Message-ID: <87ob9vozgo.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1374451763-17956-1-git-send-email-tjlee@ambarella.com> (Tzu-Jung Lee's message of "Mon, 22 Jul 2013 08:09:23 +0800")
>>>>> "T" == Tzu-Jung Lee <roylee17@gmail.com> writes:
T> Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com>
T> ---
T> v3 adopts all the review comments against v2 from Peter.
T> package/Config.in | 1 +
T> package/dropwatch/Config.in | 10 ++++++++++
T> package/dropwatch/dropwatch-1.4-build.patch | 27 ++++++++++++++++++++++++++
T> package/dropwatch/dropwatch.mk | 30 +++++++++++++++++++++++++++++
T> 4 files changed, 68 insertions(+)
T> create mode 100644 package/dropwatch/Config.in
T> create mode 100644 package/dropwatch/dropwatch-1.4-build.patch
T> create mode 100644 package/dropwatch/dropwatch.mk
T> diff --git a/package/Config.in b/package/Config.in
T> index b8011c7..1216450 100644
T> --- a/package/Config.in
T> +++ b/package/Config.in
T> @@ -22,6 +22,7 @@ source "package/cache-calibrator/Config.in"
T> source "package/dhrystone/Config.in"
T> source "package/dstat/Config.in"
T> source "package/dmalloc/Config.in"
T> +source "package/dropwatch/Config.in"
T> source "package/gdb/Config.in"
T> source "package/iozone/Config.in"
T> source "package/kexec/Config.in"
T> diff --git a/package/dropwatch/Config.in b/package/dropwatch/Config.in
T> new file mode 100644
T> index 0000000..c7fc933
T> --- /dev/null
T> +++ b/package/dropwatch/Config.in
T> @@ -0,0 +1,10 @@
T> +config BR2_PACKAGE_DROPWATCH
T> + bool "dropwatch"
T> + select BR2_PACKAGE_BINUTILS
T> + select BR2_PACKAGE_READLINE
T> + select BR2_PACKAGE_LIBNL
T> + help
T> + Dropwatch is an interactive utility for monitoring and recording packets
T> + that are dropped by the kernel
Line too long. It should be wrapped around column 70 to fit menuconfig
in a normal 80x24 terminal.
T> +++ b/package/dropwatch/dropwatch.mk
T> @@ -0,0 +1,30 @@
T> +################################################################################
T> +#
T> +# dropwatch
T> +#
T> +################################################################################
T> +
T> +DROPWATCH_VERSION = 1.4
T> +DROPWATCH_SOURCE = dropwatch-$(DROPWATCH_VERSION).tar.bz2
T> +DROPWATCH_SITE = https://git.fedorahosted.org/cgit/dropwatch.git/snapshot/
T> +DROPWATCH_DEPENDENCIES = binutils libnl readline
It uses pkg-config to find the libnl headers, so you also need
host-pkgconf.
T> +DROPWATCH_LICENSE = GPLv2+
main.c explicitly says GPLv2, and the only reference to the typical 'any
later version' is in COPYING, so it should be GPLv2
T> +DROPWATCH_LICENSE_FILE = COPYING
The variable is called ..FILES (S at the end).
Committed with these fixes, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-07-22 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 1:34 [Buildroot] [PATCH v2 1/1] dropwatch: new package Tzu-Jung Lee
2013-07-21 22:35 ` Peter Korsgaard
2013-07-22 0:00 ` Tzu-Jung Lee
2013-07-22 0:09 ` [Buildroot] [PATCH v3 " Tzu-Jung Lee
2013-07-22 6:55 ` Peter Korsgaard [this message]
2013-07-22 5:31 ` [Buildroot] [PATCH v2 " Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob9vozgo.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox