From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/spice: don't enable GUI if dependencies not met
Date: Wed, 26 Dec 2012 23:51:55 +0100 [thread overview]
Message-ID: <87obhg5svo.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <0edfe5fad92256f3d70bc151650cade9d1f6a7fa.1356459033.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Tue, 25 Dec 2012 19:11:29 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
Yann> The spice GUI selects unconditionally selects cegui06, but cegui06 requires
Yann> threads and C++, so spice GUI must also depend on threads and C++.
Yann> Fixes:
Yann> http://autobuild.buildroot.net/results/37f8ee90bb4348db97daef83493005c42a193b91/
Yann> +++ b/package/spice/Config.in
Yann> @@ -35,8 +35,13 @@ config BR2_PACKAGE_SPICE_CLIENT
Yann> select BR2_PACKAGE_XLIB_LIBXFIXES
Yann> select BR2_PACKAGE_XLIB_LIBXRANDR
Yann> +comment "GUI requires a toolchain with threads and C++"
Yann> + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
Yann> +
This comment should only be shown if SPICE_CLIENT is enabled, so I've
added the dependency and committed, thanks.
Yann> config BR2_PACKAGE_SPICE_GUI
Yann> bool "Enable GUI"
Yann> + depends on BR2_TOOLCHAIN_HAS_THREADS # cegui06
Yann> + depends on BR2_INSTALL_LIBSTDCPP # cegui06
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-12-26 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-25 18:11 [Buildroot] [pull request] Pull request for branch yem-misc-fixes Yann E. MORIN
2012-12-25 18:11 ` [Buildroot] [PATCH 1/2] package/spice: don't enable GUI if dependencies not met Yann E. MORIN
2012-12-26 22:51 ` Peter Korsgaard [this message]
2012-12-25 18:11 ` [Buildroot] [PATCH 2/2] package/keyutils: disable on avr32 Yann E. MORIN
2012-12-26 22:57 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obhg5svo.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox