Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] Bug in pkg-stats?
Date: Wed, 05 Oct 2011 21:08:07 +0200	[thread overview]
Message-ID: <87obxvntns.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F39DCFE910@AUSP01VMBX24.collaborationhost.net> (H. Hartley Sweeten's message of "Wed, 5 Oct 2011 13:52:18 -0500")

>>>>> "H" == H Hartley Sweeten <hartleys@visionengravers.com> writes:

Hi,

 >> version=$(awk -F'=| ' '/_VERSION/ { print $NF } END { print "unknown" } ' \
 >> $i | head -n 1)

 H> I thought there was some way of doing it with awk... I really need to figure
 H> out how that utility works... ;-)

;) It takes a bit of getting used to, but is quite powerful once you get it.

 >> But it naturally still doesn't work for packages with multiple versions
 >> (like busybox) or where version is major.minor (like glib2).

 H> With your awk line above, the only packages that show up strange are:

 H> util-linux		$(UTIL_LINUX_VERSION_MAJOR)
 H> xenomai		qstrip,$(BR2_PACKAGE_XENOMAI_VERSION))
 H> imagemagick		$(IMAGEMAGICK_MAJOR)-6
 H> binutils		qstrip,$(BR2_BINUTILS_VERSION))
 H> microperl		$(MICROPERL_MAJ).8.8
 H> haserl		qstrip,$(BR2_PACKAGE_HASERL_VERSION))

 H> And, of course, the ones with version major.minor only show the major version.

 H> Regardless, do you think this patch is worth submitting?

Well, I think the info in useful, but as buildroot already knows the
version (except for unconfigured packages), wouldn't it make more sense
to add a <pkg>-version target to GENTARGETS and use that instead?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-10-05 19:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 22:35 [Buildroot] Bug in pkg-stats? H Hartley Sweeten
2011-10-04 23:05 ` H Hartley Sweeten
2011-10-05  6:43   ` Thomas Petazzoni
2011-10-05 17:09     ` H Hartley Sweeten
2011-10-05 18:36       ` Peter Korsgaard
2011-10-05 18:52         ` H Hartley Sweeten
2011-10-05 19:08           ` Peter Korsgaard [this message]
2011-10-06  7:52             ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obxvntns.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox