From: Peter Korsgaard <peter@korsgaard.com>
To: <yann.morin@orange.com>
Cc: <buildroot@buildroot.org>, Julien Olivain <ju.o@free.fr>
Subject: Re: [Buildroot] [PATCH 1/2] support/testing/utils: fix get-developers test without a tty
Date: Fri, 31 Jan 2025 17:47:09 +0100 [thread overview]
Message-ID: <87plk33p82.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1f3b48c849c42f36b11d9b2ee3da8a7e812e9f47.1737357470.git.yann.morin@orange.com> (yann morin's message of "Mon, 20 Jan 2025 08:17:55 +0100")
>>>>> <yann.morin@orange.com> writes:
> From: "Yann E. MORIN" <yann.morin@orange.com>
> get-developers will check its stdin to decide whether it is a tty or
> not, and behave differently whether it is or not. So, when we run the
> tests, we need an actual tty.
> However, when running in a CI pipeline, like on Gitlab-CI, there is no
> tty available on stdin.
> Fake one. We don't need anything too fancy, so just a slave pty will
> suffice.
> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/8830671800
> Fixes: d10d22221f93 (utils/get-developers: read patch from stdin when
> it's not a tty)
> Reported-by: Julien Olivain <ju.o@free.fr>
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Committed to 2024.02.x and 2024.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-01-31 16:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 7:17 [Buildroot] [PATCH 0/2] support/tests: fix get-developers test when stdini for tests is not a tty yann.morin
2025-01-20 7:17 ` [Buildroot] [PATCH 1/2] support/testing/utils: fix get-developers test without " yann.morin
2025-01-31 16:47 ` Peter Korsgaard [this message]
2025-01-20 7:17 ` [Buildroot] [PATCH 2/2] support/testing.utils: check patch on stdin to get-developers yann.morin
2025-01-31 16:47 ` Peter Korsgaard
2025-01-20 20:20 ` [Buildroot] [PATCH 0/2] support/tests: fix get-developers test when stdini for tests is not a tty Julien Olivain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plk33p82.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=yann.morin@orange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox