From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>,
fontaine.fabrice@gmail.com
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [git commit] package/avahi: fix libavahi-client handling
Date: Sat, 13 Jan 2024 08:52:20 +0100 [thread overview]
Message-ID: <87ply5wtzf.fsf@48ers.dk> (raw)
In-Reply-To: <20240106095524.0610E81D7B@busybox.osuosl.org> (Thomas Petazzoni via buildroot's message of "Sat, 6 Jan 2024 10:51:59 +0100")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=f8332fa63d665d69f6f07524f1b320f589e1f23c
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> libavahi-client is built without daemon since bump to version 0.6.32 in
> commit 61c056d40bc51f99f8be19b7e77894a5e6565fd6 and
> https://github.com/avahi/avahi/commit/54086a11033194e629b6ad7039bcb4fb1628e052
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Oddly enough, I didn't receive the original mail from Fabrice, but it is
in the archive, so probably an issue on my side.
Does this change really make sense in the context of Buildroot? Libavahi
is a library to talk to the avahi daemon, so not very useful without the
daemon.
The original commit talks about multilib, E.G. presumably for a use case
where the daemon is built once and the library built both in 32bit and
64bit and used on the same system, but that isn't really a Buildroot use
case.
> ---
> package/avahi/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/avahi/Config.in b/package/avahi/Config.in
> index 2484d8ce5c..728bc4fdd1 100644
> --- a/package/avahi/Config.in
> +++ b/package/avahi/Config.in
> @@ -38,7 +38,7 @@ config BR2_PACKAGE_AVAHI_DAEMON
> # more easily determine if it's available or not.
> config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
> bool
> - default y if BR2_PACKAGE_AVAHI_DAEMON && BR2_PACKAGE_DBUS
> + default y if BR2_PACKAGE_DBUS
> config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY
> bool "libdns_sd compatibility (Bonjour)"
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-13 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 9:51 [Buildroot] [git commit] package/avahi: fix libavahi-client handling Thomas Petazzoni via buildroot
2024-01-13 7:52 ` Peter Korsgaard [this message]
2024-01-13 17:45 ` Thomas Petazzoni via buildroot
2024-01-13 19:56 ` Peter Korsgaard
2024-01-14 12:40 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ply5wtzf.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox