From: Peter Korsgaard <peter@korsgaard.com>
To: Neal Frager <neal.frager@amd.com>
Cc: michal.simek@amd.com, luca.ceresoli@bootlin.com,
thomas.petazzoni@bootlin.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 1/1] board/zynq: fix shellcheck issues
Date: Tue, 06 Jun 2023 21:26:22 +0200 [thread overview]
Message-ID: <87pm684ckh.fsf@48ers.dk> (raw)
In-Reply-To: <20230606144237.2802780-1-neal.frager@amd.com> (Neal Frager's message of "Tue, 6 Jun 2023 15:42:37 +0100")
>>>>> "Neal" == Neal Frager <neal.frager@amd.com> writes:
> This patch cleans up board/zynq shellcheck issues.
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> .checkpackageignore | 2 --
> board/zynq/post-build.sh | 4 ++--
> board/zynq/post-image.sh | 8 ++++----
> 3 files changed, 6 insertions(+), 8 deletions(-)
> diff --git a/.checkpackageignore b/.checkpackageignore
> index 10e70f0787..90a1481e54 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -101,8 +101,6 @@ board/udoo/common/post-build.sh Shellcheck
> board/udoo/mx6qdl/patches/linux/0000-udoo-disable-usbh1.patch Upstream
> board/versal/post-build.sh Shellcheck
> board/versal/post-image.sh Shellcheck TrailingSpace
> -board/zynq/post-build.sh Shellcheck
> -board/zynq/post-image.sh Shellcheck
> board/zynqmp/kria/kv260/kv260.sh Shellcheck
> board/zynqmp/kria/patches/uboot/v1-0001-makefile-add-multi_dtb_fit-dep.patch ApplyOrder Upstream
> board/zynqmp/post-build.sh Shellcheck
> diff --git a/board/zynq/post-build.sh b/board/zynq/post-build.sh
> index 9fd8bbf2c8..7cec673e4b 100755
> --- a/board/zynq/post-build.sh
> +++ b/board/zynq/post-build.sh
> @@ -3,6 +3,6 @@
> # genimage will need to find the extlinux.conf
> # in the binaries directory
> -BOARD_DIR="$(dirname $0)"
> +BOARD_DIR="$(dirname "$0")"
> -install -m 0644 -D $BOARD_DIR/extlinux.conf $BINARIES_DIR/extlinux.conf
> +install -m 0644 -D "$BOARD_DIR"/extlinux.conf "$BINARIES_DIR"/extlinux.conf
This is IMHO not how we should be writing these lines, but instead use
quotes around the entire word and use ${} around the variables, E.G.
install -m 0644 -D "${BOARD_DIR}/extlinux.conf" "${BINARIES_DIR}/extlinux.conf"
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-06-06 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 14:42 [Buildroot] [PATCH v1 1/1] board/zynq: fix shellcheck issues Neal Frager via buildroot
2023-06-06 19:26 ` Peter Korsgaard [this message]
2023-06-14 13:52 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm684ckh.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox