From: Peter Korsgaard <peter@korsgaard.com>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/3] package/glmark2: fix selection of dependencies
Date: Wed, 17 Nov 2021 22:59:44 +0100 [thread overview]
Message-ID: <87pmqytpdb.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211113093009.6915-3-bernd.kuhls@t-online.de> (Bernd Kuhls's message of "Sat, 13 Nov 2021 10:30:09 +0100")
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:
> Commit 9c068b4be8 (package/glmark2: fix wayland build) extended the set
> of required libraries for various "flavor" options by selecting those
> libraries from the blind options.
> However, that option is true as soon as the requirements are met (the
> depends on), even when glmark2 itself is not enabled.
> This means that extra libraries are pulled in to the build, even when
> not required.
> We fix that by moving the actual selects to the main symbol, along with
> the proper conditions. This means that we have two lines that select
> wayland-protocols, under two different conditions; we could make that a
> single select, but the codition would need to be on two lines anyway,
> so meh...
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> Requested by Yann:
> http://lists.busybox.net/pipermail/buildroot/2021-November/628389.html
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-17 21:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 9:30 [Buildroot] [PATCH v2 1/3] package/glmark2: drm-glesv2 needs libdrm Bernd Kuhls
2021-11-13 9:30 ` [Buildroot] [PATCH v2 2/3] package/glmark2: drm-glesv2 needs libgbm Bernd Kuhls
2021-11-13 9:53 ` Yann E. MORIN
2021-11-17 22:01 ` Peter Korsgaard
[not found] ` <87h7catpaz.fsf__1784.76354792423$1637186493$gmane$org@dell.be.48ers.dk>
2021-11-18 6:30 ` Bernd Kuhls
2021-11-13 9:30 ` [Buildroot] [PATCH 3/3] package/glmark2: fix selection of dependencies Bernd Kuhls
2021-11-13 9:52 ` Yann E. MORIN
2021-11-17 21:59 ` Peter Korsgaard [this message]
2021-11-13 9:53 ` [Buildroot] [PATCH v2 1/3] package/glmark2: drm-glesv2 needs libdrm Yann E. MORIN
2021-11-17 22:00 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmqytpdb.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox