From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E44C433F5 for ; Fri, 5 Nov 2021 13:26:53 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30CB5611AE for ; Fri, 5 Nov 2021 13:26:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 30CB5611AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=buildroot.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C920A82509; Fri, 5 Nov 2021 13:26:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dHhWgf4AMIYg; Fri, 5 Nov 2021 13:26:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 32E3B82503; Fri, 5 Nov 2021 13:26:51 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id EDAA21BF304 for ; Fri, 5 Nov 2021 13:26:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id DC47240748 for ; Fri, 5 Nov 2021 13:26:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WWRLZFngPS3M for ; Fri, 5 Nov 2021 13:26:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7DF7B40747 for ; Fri, 5 Nov 2021 13:26:48 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C06D21BF207; Fri, 5 Nov 2021 13:26:44 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.92) (envelope-from ) id 1mizEy-0003Hl-11; Fri, 05 Nov 2021 14:26:44 +0100 From: Peter Korsgaard To: Thomas Petazzoni References: <20211105123848.6356-1-peter@korsgaard.com> <20211105123848.6356-2-peter@korsgaard.com> <20211105141042.7ac80413@windsurf> Date: Fri, 05 Nov 2021 14:26:44 +0100 In-Reply-To: <20211105141042.7ac80413@windsurf> (Thomas Petazzoni's message of "Fri, 5 Nov 2021 14:10:42 +0100") Message-ID: <87pmreivhn.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 2/2] configs/nezha_defconfig: new defconfig X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: samuel@sholland.org, buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Thomas" == Thomas Petazzoni writes: > Howdy, > Thanks for this! It's obviously great, just a couple of nits, see below. > On Fri, 5 Nov 2021 13:38:47 +0100 > Peter Korsgaard wrote: >> diff --git a/board/nezha/post-build.sh b/board/nezha/post-build.sh >> new file mode 100755 >> index 0000000000..9d38b13b84 >> --- /dev/null >> +++ b/board/nezha/post-build.sh >> @@ -0,0 +1,6 @@ >> +#!/bin/sh >> +BOARD_DIR=$(dirname $0) >> + >> +# Bring the extlinux.conf file in >> +install -D -m 0644 ${BOARD_DIR}/extlinux.conf \ >> + ${TARGET_DIR}/boot/extlinux/extlinux.conf > Probably you don't even need a post-build script here, the > extlinux.conf could just be added to the rootfs using a rootfs overlay. Sure, that works as well. As maybe is obvious I copied this from beaglev. I can change to a rootfs overlay if that is nicer. >> new file mode 100644 >> index 0000000000..f04404b9a4 >> --- /dev/null >> +++ b/configs/nezha_defconfig >> @@ -0,0 +1,36 @@ >> +BR2_riscv=y >> +BR2_GLOBAL_PATCH_DIR="board/nezha/patches" >> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_14=y >> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/nezha/post-build.sh" >> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh" >> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/nezha/genimage.cfg" >> +BR2_LINUX_KERNEL=y >> +BR2_LINUX_KERNEL_CUSTOM_GIT=y >> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/smaeul/linux.git" >> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="012f5a3d01be6d44e32c74bb3637ec281790b297" > Here... >> +BR2_TARGET_OPENSBI=y >> +BR2_TARGET_OPENSBI_CUSTOM_GIT=y >> +BR2_TARGET_OPENSBI_CUSTOM_REPO_URL="https://github.com/smaeul/opensbi" >> +BR2_TARGET_OPENSBI_CUSTOM_REPO_VERSION="b9125c6f8909d1cc0417795737fc13cb6297ff11" > Here... >> +BR2_TARGET_UBOOT_CUSTOM_GIT=y >> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/smaeul/u-boot" >> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="62392d3b8a624a80646c1876533336f90140088d" > .. and here > We normally use the github macro to download a tarball instead of a > full Git repository. We could do that as well. I didn't do it as I'm expecting (hoping) to see quite some updates here, but I can change it for the defconfig. I'll wait a bit to see if there is other feedback and then send a v2 changing the above. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot