From: Joachim Wiberg <troglobit@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/sysklogd: bump to verson 2.2.0
Date: Sun, 24 Jan 2021 16:51:31 +0100 [thread overview]
Message-ID: <87pn1uuyd8.fsf@gmail.com> (raw)
In-Reply-To: <20210124152831.GA2325@scaer>
Hi Yann!
On Sun, Jan 24, 2021 at 16:28, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> On 2021-01-24 16:22 +0100, Joachim Wiberg spake thusly:
>> I apologize for the confusion and head scratching this has caused!
> No need for an apology ;-)
You're too kind :)
>> I see, for past sysklogd that worked. Now we provide the logger tool
>> as well, and --exec-prefix=/ changes to /bin/logger and /sbin/syslogd.
>> Since BusyBox logger is in /usr/bin,
> Ah, this is the kind of explanations that should go in a commit message!
Yup
> Indeed, a commit message that just describes the changes is not very
> helpful. What is important in a commit message is to explain what the
> problem is and why the change fixes it.
This is exactly what I'm preaching to our junior devs (sometimes on a
daily basis) at $DAYJOB. So it's a painful realization that when push
comes to shove, I'm no better myself LOL :-)
Best regards
/Joachim
next prev parent reply other threads:[~2021-01-24 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 15:43 [Buildroot] [PATCH 0/3] package/sysklogd: version bump, some fixes, and more menuconfig Joachim Wiberg
2021-01-22 15:43 ` [Buildroot] [PATCH 1/3] package/sysklogd: bump to verson 2.2.0 Joachim Wiberg
2021-01-24 9:36 ` Yann E. MORIN
2021-01-24 15:22 ` Joachim Wiberg
2021-01-24 15:28 ` Yann E. MORIN
2021-01-24 15:51 ` Joachim Wiberg [this message]
2021-01-22 15:43 ` [Buildroot] [PATCH 2/3] package/sysklogd: add menuconfig support for enabling native logger Joachim Wiberg
2021-01-22 15:43 ` [Buildroot] [PATCH 3/3] package/sysklogd: menuconfig support for remote syslog retry delay Joachim Wiberg
2021-01-24 9:40 ` [Buildroot] [PATCH 0/3] package/sysklogd: version bump, some fixes, and more menuconfig Yann E. MORIN
2021-01-24 15:25 ` Joachim Wiberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn1uuyd8.fsf@gmail.com \
--to=troglobit@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox