From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix rasberry Pi 64bit firmware overlay inclusion
Date: Wed, 24 Apr 2019 22:15:08 +0200 [thread overview]
Message-ID: <87pnpb88j7.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <6de3ad34-84b1-842f-07e3-6c34734bd1b3@mind.be> (Arnout Vandecappelle's message of "Sun, 14 Apr 2019 00:13:12 +0200")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
> On 13/04/2019 23:06, Yann E. MORIN wrote:
>> Matt, All,
>>
>> On 2019-01-03 22:00 +1100, Matt Flax spake thusly:
>>> This patch enables the inclusion of the Pi's overlays. Previously
>>> the overlays were not included in the genimage configuration.
>>> This patch ensures overlays are included in the sdcard (when
>>> enabled) by defaulting to the inclusion of an empty
>>> output/images/rpi-firmware/overlays directory in genimage cfg.
>>>
>>> The Pi's overlays are built with the following config
>>> variables:
>>> BR2_PACKAGE_RPI_FIRMWARE=y
>>> BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS=y
>>> BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS=y
>>> BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y
>>> BR2_LINUX_KERNEL_IMAGE_NAME="Image"
>>> BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="Image modules dtbs"
>>>
>>> After building, the dtbo files are present in the
>>> output/images/rpi-firmware/overlays directory but not added
>>> to the sdcard because they are missing from the genimage cfg
>>> file.
>>>
>>> Signed-off-by: Matt Flax <flatmax@flatmax.org>
>>
> Also, I've added a brief comment explaining why we create this empty directory.
> Peter, we discussed this on IRC and we feel that one empty directory doesn't
> violate the minimalistic principle too much, because it does make life a lot
> easier when you start from the existing defconfig.
> So, I've applied to master with the changes mentioned above.
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-04-24 20:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 11:00 [Buildroot] [PATCH 1/1] Fix rasberry Pi 64bit firmware overlay inclusion Matt Flax
2019-01-04 19:50 ` Peter Seiderer
2019-01-04 23:08 ` Matt Flax
2019-01-05 15:17 ` Peter Seiderer
2019-01-06 1:11 ` Matt Flax
2019-01-06 18:31 ` Peter Seiderer
2019-01-06 21:52 ` Matt Flax
2019-04-13 21:06 ` Yann E. MORIN
2019-04-13 22:13 ` Arnout Vandecappelle
2019-04-24 20:15 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnpb88j7.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox