Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/acpitool: needs threads, shared; unavailable for bfin
Date: Wed, 28 Sep 2016 07:49:19 +0200	[thread overview]
Message-ID: <87pono1sm8.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1475013911-32258-1-git-send-email-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Wed, 28 Sep 2016 00:05:11 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > acpitool requires threads.
 > However, it does not check fo threads in its configure script, so
 > forgets to link with -pthreads, so fails to build in static-only
 > scenarii.

 > However, upstream has been dead for the past 7+ years now, so there is
 > not much point trying to fix this. Besides, a system with ACPI is most
 > probably a biggish system, so shared libs will probably be enabled, so
 > we just require shared libs.

 > As for bfin, the cryptic configure failure:
 >     configure: error: C++ compiler cannot create executables

 > is due to the order in which AC_PROG_CXX and AC_PROG_CC are called.
 > Calling AC_PROG_CC first fixes this error message.

Didn't we conclude this was a toolchain issue?

 > Since there's not many chances that a bfin board has ACPI, we just
 > disable acpitool for bfin.

Agreed.

 > ---
 > Changes v1 -> v2:
 >   - add dependencies on threads and !static

You seem to have forgotten to actually do so?

-- 
Venlig hilsen,
Peter Korsgaard 

  reply	other threads:[~2016-09-28  5:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27 22:05 [Buildroot] [PATCH] package/acpitool: needs threads, shared; unavailable for bfin Yann E. MORIN
2016-09-28  5:49 ` Peter Korsgaard [this message]
2016-09-28 16:37   ` Yann E. MORIN
  -- strict thread matches above, loose matches on Subject: below --
2016-09-28 16:42 Yann E. MORIN
2016-09-28 20:13 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pono1sm8.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox