Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] tcpreplay: cross-compile with tcpdump support
Date: Thu, 23 Jan 2014 12:30:41 +0100	[thread overview]
Message-ID: <87ppnjaqam.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1390468034-7430-1-git-send-email-judge.packham@gmail.com> (Chris Packham's message of "Thu, 23 Jan 2014 22:07:14 +1300")

>>>>> "Chris" == Chris Packham <judge.packham@gmail.com> writes:

 > If tcpdump is enabled set ac_cv_path_tcpdump_path so that verbose output
 > is enabled on the target.

 > Signed-off-by: Chris Packham <judge.packham@gmail.com>
 > ---
 > Hi,

 > This should get verbose support working if the tcpdump package is selected.
 > This may also fix some of the build errors (if they set BR2_PACKAGE_TCPDUMP=y)
 > but the real fix will come from upstream.

 >  package/tcpreplay/tcpreplay.mk | 6 ++++++
 >  1 file changed, 6 insertions(+)

 > diff --git a/package/tcpreplay/tcpreplay.mk b/package/tcpreplay/tcpreplay.mk
 > index 0939c6c..a2cd16e 100644
 > --- a/package/tcpreplay/tcpreplay.mk
 > +++ b/package/tcpreplay/tcpreplay.mk
 > @@ -18,4 +18,10 @@ TCPREPLAY_DEPENDENCIES = libpcap
 >  TCPREPLAY_LIBS = -lpcap $(if $(BR2_PACKAGE_LIBUSB),-lusb-1.0)
 >  TCPREPLAY_CONF_ENV += ac_cv_search_pcap_close='$(TCPREPLAY_LIBS)'
 
 > +ifeq ($(BR2_PACKAGE_TCPDUMP),y)
 > +TCPREPLAY_CONF_ENV += ac_cv_path_tcpdump_path=/usr/sbin/tcpdump

The problem here is that the configure script checks if /usr/bin/tcpdump
(on the build machine) is executable, and otherwise errors out - So this
breaks if you try to build it on a machine without tcpdump.

The configure script needs to be changed to not do this test when cross
compiling (or only warn).

 > +else
 > +TCPREPLAY_CONF_ENV += ac_cv_path_tcpdump_path=no
 > +endif
 > +
 >  $(eval $(autotools-package))
 > -- 
 > 1.8.4.rc2



-- 
Bye, Peter Korsgaard

  reply	other threads:[~2014-01-23 11:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-21 10:41 [Buildroot] [PATCH 1/1] Fixed tcpreplay auto build errors Martin Bark
2014-01-22  3:07 ` Chris Packham
2014-01-22  8:58   ` Peter Korsgaard
2014-01-23  0:54     ` Chris Packham
2014-01-23  7:37       ` Peter Korsgaard
2014-01-23  9:07         ` [Buildroot] [PATCH] tcpreplay: cross-compile with tcpdump support Chris Packham
2014-01-23 11:30           ` Peter Korsgaard [this message]
2014-01-23 20:08             ` Martin Bark
2014-01-23 21:31               ` Peter Korsgaard
2014-01-23 22:47                 ` Chris Packham
2014-01-27 14:26                   ` Peter Korsgaard
2014-01-28  9:37                     ` [Buildroot] [PATCH] tcpreplay: Bump version to 4.0.2 Chris Packham
2014-01-28 10:28                       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppnjaqam.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox