Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3 of 3] linux/uboot: line-up repository-related configuration options
Date: Mon, 22 Jul 2013 00:11:36 +0200	[thread overview]
Message-ID: <87ppubr2av.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <3c808c389a7d8a39cfaf.1374233234@BEANTN0L019720> (Thomas De Schampheleire's message of "Fri, 19 Jul 2013 13:27:14 +0200")

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

 Thomas> Although the configuration options for custom repository locations and
 Thomas> versions are very similar between the linux and uboot packages, there are
 Thomas> some minor differences. This patch lines up both packages.

 Thomas> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

 Thomas> ---
 Thomas> Note: one remaining difference is that there are help texts in linux for
 Thomas> options BR2_LINUX_KERNEL_CUSTOM_GIT and BR2_LINUX_KERNEL_CUSTOM_HG. I
 Thomas> didn't add them to uboot because it seems a bit redundant, but if you
 Thomas> prefer we can line this up as well (either add help texts to uboot or
 Thomas> remove them from linux).

 Thomas>  boot/uboot/Config.in |  5 +++++
 Thomas>  linux/Config.in      |  2 +-
 Thomas>  2 files changed, 6 insertions(+), 1 deletions(-)

 Thomas> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
 Thomas> --- a/boot/uboot/Config.in
 Thomas> +++ b/boot/uboot/Config.in
 Thomas> @@ -70,6 +70,11 @@ config BR2_TARGET_UBOOT_CUSTOM_REPO_URL
 
 Thomas>  config BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION
 Thomas>  	string "Custom repository version"
 Thomas> +	default "HEAD" if BR2_TARGET_UBOOT_CUSTOM_GIT
 Thomas> +	default "tip" if BR2_TARGET_UBOOT_CUSTOM_HG
 Thomas> +	help
 Thomas> +	  Revision to use in the typical format used by Git/Mercurial
 Thomas> +	  E.G. a sha id, a tag, branch, ..

As mentioned for the linux change, I prefer to drop the defaults,
otherwise it looks good.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-07-21 22:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 11:27 [Buildroot] [PATCH 0 of 3] linux/uboot: add support for custom Mercurial repositories Thomas De Schampheleire
2013-07-19 11:27 ` [Buildroot] [PATCH 1 of 3] linux: add support for custom Mercurial repository Thomas De Schampheleire
2013-07-21 22:09   ` Peter Korsgaard
2013-07-19 11:27 ` [Buildroot] [PATCH 2 of 3] u-boot: " Thomas De Schampheleire
2013-07-21 22:10   ` Peter Korsgaard
2013-07-19 11:27 ` [Buildroot] [PATCH 3 of 3] linux/uboot: line-up repository-related configuration options Thomas De Schampheleire
2013-07-21 22:11   ` Peter Korsgaard [this message]
2013-07-22  6:49     ` Thomas De Schampheleire
  -- strict thread matches above, loose matches on Subject: below --
2013-03-26 18:42 [Buildroot] [PATCH 0 of 3] linux/uboot: add support for custom Mercurial repositories Thomas De Schampheleire
2013-03-26 18:42 ` [Buildroot] [PATCH 3 of 3] linux/uboot: line-up repository-related configuration options Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppubr2av.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox