From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mplayer: fix compilation of NEON assembly in libavcodec
Date: Mon, 08 Oct 2012 22:27:46 +0200 [thread overview]
Message-ID: <87pq4s3e0t.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1349478193-13673-1-git-send-email-arnout@mind.be> (Arnout Vandecappelle's message of "Sat, 6 Oct 2012 01:03:13 +0200")
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Arnout> Compilation of the NEON assembly fails unless neon is enabled in the
Arnout> compiler options. This is probably not needed for all combinations of
Arnout> gcc/binutils, but at least some need it and it certainly doesn't hurt.
Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Arnout> ---
Arnout> .../multimedia/mplayer/mplayer-1.1-fix-neon.patch | 19 +++++++++++++++++++
Arnout> 1 file changed, 19 insertions(+)
Arnout> diff --git a/package/multimedia/mplayer/mplayer-1.1-fix-neon.patch b/package/multimedia/mplayer/mplayer-1.1-fix-neon.patch
Arnout> new file mode 100644
Arnout> index 0000000..38c2adc
Arnout> --- /dev/null
Arnout> +++ b/package/multimedia/mplayer/mplayer-1.1-fix-neon.patch
Arnout> @@ -0,0 +1,19 @@
Arnout> +Compilation of the NEON assembly fails unless neon is enabled in the
Arnout> +compiler options. This is probably not needed for all combinations of
Arnout> +gcc/binutils, but at least some need it and it certainly doesn't hurt.
Arnout> +
Arnout> +Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Arnout> +---
Arnout> +diff -Nrup mplayer-1.1.orig/configure mplayer-1.1/configure
Arnout> +--- mplayer-1.1.orig/configure 2012-10-06 00:31:57.706985824 +0200
Arnout> ++++ mplayer-1.1/configure 2012-10-06 00:49:32.618948116 +0200
Arnout> +@@ -2935,6 +2935,9 @@ if arm ; then
Arnout> + inline_asm_check '"vadd.i16 q0, q0, q0"' && neon=yes
Arnout> + fi
Arnout> + echores "$neon"
Arnout> ++ if test $neon = "yes" ; then
Arnout> ++ extra_cflags="$extra_cflags -mfpu=neon -mfloat-abi=softfp"
Why softfp? Is that just an optimization or is it needed? How does that
work with a hardfp toolchain/libraries?
Please document why this is needed (if it is) in the commit message and
resubmit, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-10-08 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 23:03 [Buildroot] [PATCH] mplayer: fix compilation of NEON assembly in libavcodec Arnout Vandecappelle
2012-10-05 23:45 ` Sagaert Johan
2012-10-08 20:27 ` Peter Korsgaard [this message]
2012-10-09 21:29 ` Arnout Vandecappelle
2012-10-10 9:13 ` Peter Korsgaard
2012-10-15 6:53 ` Peter Korsgaard
2012-10-15 19:05 ` Arnout Vandecappelle
2012-10-15 20:49 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq4s3e0t.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox