From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 04/14] libeina: Add new package along with EFL infrastructure
Date: Thu, 26 Jan 2012 23:03:15 +0100 [thread overview]
Message-ID: <87pqe6ceak.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAFbHwiT0gRXscpUTjtzdwGRruwKETPcmW-zS+eGrqAHfYQnJQw@mail.gmail.com> (Will Newton's message of "Thu, 26 Jan 2012 17:42:25 +0000")
>>>>> "Will" == Will Newton <will.newton@gmail.com> writes:
Will> Signed-off-by: Will Newton <will.newton@imgtec.com>
Will> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Will> ---
Will> +++ b/package/efl/libeina/Config.in
Will> @@ -0,0 +1,4 @@
Will> +config BR2_PACKAGE_LIBEINA
Will> + bool "libeina"
Will> + help
Will> + Eina is a tiny library to handle data types (list, hash, etc.)
Heh, the compressed tarball is almost 10MB.
You forgot to add an upstream URL. I've added
http://trac.enlightenment.org/e/wiki/Eina
Will> diff --git a/package/efl/libeina/libeina.mk b/package/efl/libeina/libeina.mk
Will> new file mode 100644
Will> index 0000000..3ed43db
Will> --- /dev/null
Will> +++ b/package/efl/libeina/libeina.mk
Will> @@ -0,0 +1,16 @@
Will> +#############################################################
Will> +#
Will> +# libeina
Will> +#
Will> +#############################################################
Will> +
Will> +LIBEINA_VERSION = 1.1.0
Will> +LIBEINA_SOURCE = eina-$(LIBEINA_VERSION).tar.bz2
Will> +LIBEINA_SITE = http://download.enlightenment.org/releases/
Will> +LIBEINA_AUTORECONF = YES
You're not patching any auto* files, so no need to autoreconf.
Otherwise it looks good - Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-01-26 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 17:42 [Buildroot] [PATCH 04/14] libeina: Add new package along with EFL infrastructure Will Newton
2012-01-26 22:03 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-23 16:35 Will Newton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqe6ceak.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox