Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] xorg-server not using target cflags
Date: Sat, 27 Nov 2010 22:25:03 +0100	[thread overview]
Message-ID: <87pqtq1mts.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <BAY145-w13F5F6FEBA012526351555C2220@phx.gbl> (Matt Johnson's message of "Fri, 26 Nov 2010 17:42:12 -0700")

>>>>> "Matt" == Matt Johnson <mj1856@hotmail.com> writes:

 Matt> Hello,
 
 Matt> I'm relatively new to buildroot, but I've had some recent success
 Matt> with most of the system.  However, I have been having problems
 Matt> getting X to run on my target platform, which is a custom s3c2410
 Matt> board. Trying to run Xfbdev always caused an Illegal Instruction
 Matt> error.
 
 Matt> I'm using a CodeSourcery external toolchain, and it requires
 Matt> -march=armv4t to be supplied, or it builds with armv5t
 Matt> instructions by default.  This hasn't been a problem for most
 Matt> packages, but I found that for the xserver_xorg-server package,
 Matt> none of the CFLAGS were being set properly.
 
 Matt> I found that the
 Matt> /package/x11r7/xserver_xorg-server/xserver_xorg-server.mk file
 Matt> has overridden the CFLAGS to include the pixman-1 library.  In
 Matt> doing so, it appear that the regular CFLAGS are no longer passed
 Matt> along.  I was able to fix this by including $(TARGET_CFLAGS) as
 Matt> well.  This seems like the best way to resolve the problem
 Matt> properly.
 
 
 Matt> I no longer get the Illegal Instruction error, and it appears to launch X properly now.
 
 
 Matt> Assuming this fix is ok, please apply the following patch to buildroot to close this bug.

Thanks, committed. Could you in the future use unified diffs (diff -u),
please? - Or even better use git and 'git format-patch'.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-11-27 21:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-27  0:42 [Buildroot] xorg-server not using target cflags Matt Johnson
2010-11-27 21:25 ` Peter Korsgaard [this message]
2010-11-28  1:00   ` Matt Johnson
2010-11-28 10:11     ` Peter Korsgaard
2010-11-29  3:55       ` [Buildroot] packages " Matt Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqtq1mts.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox