Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Brandon Maier via buildroot <buildroot@buildroot.org>
Cc: Brandon Maier <brandon.maier@collins.com>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/gmp: fix target build with host gcc 4.9
Date: Mon, 25 Mar 2024 10:04:34 +0100	[thread overview]
Message-ID: <87r0fyd6n1.fsf@48ers.dk> (raw)
In-Reply-To: <20240315234316.17513-1-brandon.maier@collins.com> (Brandon Maier via buildroot's message of "Fri, 15 Mar 2024 23:43:16 +0000")

>>>>> "Brandon" == Brandon Maier via buildroot <buildroot@buildroot.org> writes:

 > GMP does not build if the host gcc is v4.9 due to the following error
 >   gen-sieve.c: In function 'setmask':
 >   gen-sieve.c:99:3: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
 >      for (unsigned i = 0; i < 2 * a * b; ++i)
 >      ^
 >   gen-sieve.c:99:3: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code

 > The gen-sieve utility was added in GMP v6.3.0. It is built using
 > CC_FOR_BUILD (host compiler) during cross compilation as it generates
 > build files. Autoconf does not have a macro for add -std=c99 to
 > CC_FOR_BUILD, so it must be set manually.

 > Signed-off-by: Brandon Maier <brandon.maier@collins.com>
 > ---
 > v1: https://patchwork.ozlabs.org/project/buildroot/patch/20240312190954.71227-1-brandon.maier@collins.com/

 > v2:
 > - remove unnecessary comment and ifdef check

Committed to 2024.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2024-03-25  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 19:09 [Buildroot] [PATCH 1/1] package/gmp: fix target build with host gcc 4.9 Brandon Maier via buildroot
2024-03-15 20:43 ` Arnout Vandecappelle via buildroot
2024-03-15 23:37   ` [Buildroot] [External] " Maier, Brandon Collins via buildroot
2024-03-15 23:43 ` [Buildroot] [PATCH v2 " Brandon Maier via buildroot
2024-03-24 15:44   ` Arnout Vandecappelle via buildroot
2024-03-25  9:04   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0fyd6n1.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=brandon.maier@collins.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox