From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Thomas Devoogdt <thomas@devoogdt.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/fluent-bit: fix build with BR2_TIME_BITS_64
Date: Mon, 04 Mar 2024 22:48:22 +0100 [thread overview]
Message-ID: <87r0gp1xeh.fsf@48ers.dk> (raw)
In-Reply-To: <20240304153539.3372042-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Mon, 4 Mar 2024 16:35:39 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Do not remove _FILE_OFFSET_BITS=64 from CFLAGS to avoid the following
> build failure with BR2_TIME_BITS_64 raised since commit
> 3c427c64726560ea1743282a3fdb78f5b28692eb:
> In file included from /home/thomas/autobuild/instance-1/output-1/host/microblaze-buildroot-linux-gnu/sysroot/usr/include/features.h:394,
> from /home/thomas/autobuild/instance-1/output-1/host/microblaze-buildroot-linux-gnu/sysroot/usr/include/bits/libc-header-start.h:33,
> from /home/thomas/autobuild/instance-1/output-1/host/microblaze-buildroot-linux-gnu/sysroot/usr/include/stdio.h:27,
> from /home/thomas/autobuild/instance-1/output-1/build/fluent-bit-2.1.7/tools/xxd-c/xxd-c.c:27:
> /home/thomas/autobuild/instance-1/output-1/host/microblaze-buildroot-linux-gnu/sysroot/usr/include/features-time64.h:26:5: error: #error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
> 26 | # error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
> | ^~~~~
> Indeed, this LFS workaround was present since the addition of the
> package in commit 6a0f7c39bcb48fc13aa2ce3fc4996baf1be66483 and is
> only needed to fix a build failure with the old codesourcery-arm
> toolchain from 2014 which uses glibc < 2.23. as glibc 2.23 was released
> in February 2016: https://sourceware.org/glibc/wiki/Release/2.23, drop
> this workaround as already done for libselinux in commit
> c1fa9bc2f7a4e5481edf4fce5c03dd45862fe72c. A follow-up patch will also
> drop codesourcery-arm toolchain.
> Fixes: 3c427c64726560ea1743282a3fdb78f5b28692eb
> - http://autobuild.buildroot.org/results/ff5c60cd038550453ce138fe2a9383af2f5d6f2f
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
> - Update commit message
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-03-04 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 15:35 [Buildroot] [PATCH v2, 1/1] package/fluent-bit: fix build with BR2_TIME_BITS_64 Fabrice Fontaine
2024-03-04 21:48 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0gp1xeh.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox