From: Peter Korsgaard <peter@korsgaard.com>
To: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit] package/nodejs: fix parallel build further
Date: Sat, 30 Sep 2023 12:35:18 +0200 [thread overview]
Message-ID: <87r0mg9cex.fsf@48ers.dk> (raw)
In-Reply-To: <20230928201215.5296482AEA@busybox.osuosl.org> (Yann E. MORIN's message of "Thu, 28 Sep 2023 22:05:26 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=d574e2a4f440903a0e32de6deb8275b1f385da2e
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> Commit 84c24ab1b5a7 (package/nodejs: fix parallel build) made use of
> BR2_JLEVEL to set the number of jobs nodejs should use instead of using
> the number of CPUs (+2).
> However, BR2_JLEVEL can be set to 0 by the user, to let Buildroot detect
> the number of CPUs (+1), and stores it in PARALLEL_JOBS, and leaves
> BR2_JLEVEL untouched, so 0.
> Thus, we can end up spawning a build by passing -j0 to ninja, which it
> interprets as "no -limit yolo" and does not limit the number oj jobs it
> spawns, which usually ends up in an OOM somewhere...
> Fix this by using PARALLEL_JOBS.
> Reported-by: Cédric & Co
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Committed to 2023.02.x and 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-30 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 20:05 [Buildroot] [git commit] package/nodejs: fix parallel build further Yann E. MORIN
2023-09-30 10:35 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0mg9cex.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox