From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Romain Naour <romain.naour@gmail.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 1/1] toolchain/helpers.mk: fix uclibc locale support
Date: Thu, 14 Sep 2023 10:28:51 +0200 [thread overview]
Message-ID: <87r0n1xinw.fsf@48ers.dk> (raw)
In-Reply-To: <20230830234632.29121f26@windsurf> (Thomas Petazzoni via buildroot's message of "Wed, 30 Aug 2023 23:46:32 +0200")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Tue, 21 Feb 2023 15:35:33 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>> locale_t is defined by uclibc in xlocale.h:
>> https://github.com/wbx-github/uclibc-ng/blob/ab1dd83bec59c9e65c31efd6e887182948f627be/include/xlocale.h#L46
>>
>> As a result, without xlocale, locale is not fully enabled which will
>> result in the following build failure with
>> toolchain-external-synopsys-arc and libcpprestsdk:
>>
>> In file included from /home/thomas/autobuild/instance-0/output-1/build/libcpprestsdk-2.10.18/Release/include/cpprest/json.h:18,
>> from /home/thomas/autobuild/instance-0/output-1/build/libcpprestsdk-2.10.18/Release/src/pch/stdafx.h:88,
>> from /home/thomas/autobuild/instance-0/output-1/build/libcpprestsdk-2.10.18/Release/src/http/client/http_client_msg.cpp:13:
>> /home/thomas/autobuild/instance-0/output-1/build/libcpprestsdk-2.10.18/Release/include/cpprest/asyncrt_utils.h:317:13: error: 'locale_t' does not name a type
>> 317 | typedef locale_t xplat_locale;
>> | ^~~~~~~~
>>
>> Fixes:
>> - http://autobuild.buildroot.org/results/e6778e60cc1ea455f5b4511d5824f04d8040f67b
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> toolchain/helpers.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> I've applied this one to master, after squashing it with
> "toolchain/toolchain-external/toolchain-external-synopsys-arc: drop
> locale", and writing a better commit log. See:
> https://gitlab.com/buildroot.org/buildroot/-/commit/3c8d890c1946308f5396aa6428da5274b25c3a5f
> Thanks a lot!
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-14 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 14:35 [Buildroot] [PATCH 1/1] toolchain/helpers.mk: fix uclibc locale support Fabrice Fontaine
2023-08-30 21:46 ` Thomas Petazzoni via buildroot
2023-09-14 8:28 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0n1xinw.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox