From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <bernd@kuhls.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] libgcrypt: disable assembly for i386
Date: Mon, 17 Jul 2023 13:50:32 +0200 [thread overview]
Message-ID: <87r0p6ah9z.fsf@48ers.dk> (raw)
In-Reply-To: <20230703200618.GK2510@scaer> (Yann E. MORIN's message of "Mon, 3 Jul 2023 22:06:18 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Bernd, All,
> On 2023-07-03 22:03 +0200, Yann E. MORIN spake thusly:
>> On 2023-07-02 16:48 +0200, Bernd Kuhls spake thusly:
>> > Fixes:
>> > http://autobuild.buildroot.net/results/3df/3df96fe36802d8c6ac5487bf3d7d7b6c97591d5e/
>> >
>> > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>> > ---
>> > package/libgcrypt/libgcrypt.mk | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/package/libgcrypt/libgcrypt.mk b/package/libgcrypt/libgcrypt.mk
>> > index 4fffe5360e..bd7b1aa091 100644
>> > --- a/package/libgcrypt/libgcrypt.mk
>> > +++ b/package/libgcrypt/libgcrypt.mk
>> > @@ -21,8 +21,8 @@ LIBGCRYPT_CONF_OPTS = \
>> > $(if $(BR2_OPTIMIZE_0),--disable-ppc-crypto-support,) \
>> > --with-gpg-error-prefix=$(STAGING_DIR)/usr
>> >
>> > -# Libgcrypt doesn't support assembly for coldfire
>> > -ifeq ($(BR2_m68k_cf),y)
>> > +# Libgcrypt doesn't support assembly for coldfire & i386
>>
>> This is relatively weird, especially, since they do have upstream commit
>> that try to make it work on "old CPUs":
>>
>> a5d126c61cc0 configure: fix avx512 check for i386
>> f01d4b7a601f mpi/longlong.h: i386: use tzcnt instruction for trailing zeros
>>
>> So maybe this is a bug that should be reported and fixed upstream?
> Anyway: applied to master, thanks.
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-17 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 14:48 [Buildroot] [PATCH 1/1] libgcrypt: disable assembly for i386 Bernd Kuhls
2023-07-03 20:03 ` Yann E. MORIN
2023-07-03 20:06 ` Yann E. MORIN
2023-07-17 11:50 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0p6ah9z.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox