Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] strace: fix build for no-MMU targets
Date: Thu, 11 Mar 2021 16:51:18 +0200	[thread overview]
Message-ID: <87r1klagm1.fsf@tarshish> (raw)
In-Reply-To: <479cffd2532537c8d913d9c43ef4c582871ebef4.1615438767.git.baruch@tkos.co.il>

Hi Buildroot list,

On Thu, Mar 11 2021, Baruch Siach wrote:
> Add patch to disable fork() calling code on !HAVE_FORK.

I forgot the reference to autobuild failure.

Fixes:
http://autobuild.buildroot.net/results/3d506e2f6337327c0783cf3cc12a8b5fb78521e4/

baruch

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  ...et_syscall_info-disable_ptrace_getre.patch | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 package/strace/0001-disable_ptrace_get_syscall_info-disable_ptrace_getre.patch
>
> diff --git a/package/strace/0001-disable_ptrace_get_syscall_info-disable_ptrace_getre.patch b/package/strace/0001-disable_ptrace_get_syscall_info-disable_ptrace_getre.patch
> new file mode 100644
> index 000000000000..1367d2985a0f
> --- /dev/null
> +++ b/package/strace/0001-disable_ptrace_get_syscall_info-disable_ptrace_getre.patch
> @@ -0,0 +1,33 @@
> +From 84536a993417f3bfff4a54830fa34a3f91f5716e Mon Sep 17 00:00:00 2001
> +From: Baruch Siach <baruch@tkos.co.il>
> +Date: Thu, 11 Mar 2021 06:43:26 +0200
> +Subject: [PATCH] disable_ptrace_get_syscall_info, disable_ptrace_getregset:
> + require fork()
> +
> +These helper programs require fork(), so they are incompatible with
> +no-MMU systems. Make the code depend on HAVE_FORK.
> +
> +Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> +---
> +Upstream status: https://lists.strace.io/pipermail/strace-devel/2021-March/010421.html
> +
> + src/disable_ptrace_request.c | 3 ++-
> + 1 file changed, 2 insertions(+), 1 deletion(-)
> +
> +diff --git a/src/disable_ptrace_request.c b/src/disable_ptrace_request.c
> +index 57163e77f0f4..715006941572 100644
> +--- a/src/disable_ptrace_request.c
> ++++ b/src/disable_ptrace_request.c
> +@@ -41,7 +41,8 @@ init(int argc, char **argv)
> +  && defined PR_SET_NO_NEW_PRIVS \
> +  && defined PR_SET_SECCOMP \
> +  && defined BPF_JUMP \
> +- && defined BPF_STMT
> ++ && defined BPF_STMT \
> ++ && defined HAVE_FORK
> + 
> + static unsigned int
> + get_arch(void)
> +-- 
> +2.30.1

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2021-03-11 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11  4:59 [Buildroot] [PATCH] strace: fix build for no-MMU targets Baruch Siach
2021-03-11 14:51 ` Baruch Siach [this message]
2021-03-11 21:01 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1klagm1.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox