From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Revert "package/php: fix building pcre extension"
Date: Sat, 19 Jan 2019 22:35:10 +0100 [thread overview]
Message-ID: <87r2d81gc1.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190116210016.22121-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Wed, 16 Jan 2019 22:00:15 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> This reverts commit 745f884e41b5f350296e8448f5fc31d20f67a077.
> This was the wrong fix: issue is that php moves from pcre to pcre2 since
> version 7.3.0 and
> http://github.com/php/php-src/commit/a5bc5aed71f7a15f14f33bb31b8e17bf5f327e2d
> This patch will always disable external pcre2 support and raise a build
> failure when toolchaine does not have pthread
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-01-19 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 21:00 [Buildroot] [PATCH 1/2] Revert "package/php: fix building pcre extension" Fabrice Fontaine
2019-01-16 21:00 ` [Buildroot] [PATCH 2/2] php: switch to pcre2 Fabrice Fontaine
2019-01-19 21:22 ` Adam Duskett
2019-01-19 21:35 ` Peter Korsgaard
2019-01-19 21:35 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2d81gc1.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox