[Buildroot] [PATCH 4/5] system: default to empty issue/hostname for custom skeleton

[Peter Korsgaard <jacmet@uclibc.org>]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: Sagaert Johan <sagaert.johan@skynet.be>
 > A custom skeleton may include /etc/issue and/or /etc/hostname, in
 > which case we do not want to override them.

 > But those files could also be missing from the custom skeleton, or
 > the user may want to override their content.

 > Make the current default value for isue and hostname depend on the
 > generic skeleton, and default to empty for a custom skeleton.

 > Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
 > [yann.morin.1998 at free.fr: change from hiding it behind SKELETON_DEFAULT
 >     to use conditional default values; move below the skeleton choice;
 >     improve help entries]
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Do we really need to add this extra complexity? A custom skeleton is not
recommended (and in any case an advanced option), and the fix for
people not wanting /etc/issues / hostname overwritten is very easy, they
can just set it to the empty string.

What do others say?

-- 
Bye, Peter Korsgaard