From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] xlib_libX11: compile makekeys for the host correctly
Date: Tue, 21 Dec 2010 14:20:30 +0100 [thread overview]
Message-ID: <87r5dbuush.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <90d05a2a9ac9123d0fab7f68c31d58feb627d16a.1292937286.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Tue, 21 Dec 2010 14:14:53 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> As reported by Miroslav Ignjatovic in bug #2983, our hack in
Thomas> xlib_libX11 to build makekeys for the host does not work, for several
Thomas> reasons:
Thomas> * As we are building a tool for the host, we shouldn't pass
Thomas> -I$(STAGING_DIR)/usr/include, since the $(STAGING_DIR) contains
Thomas> headers of packages for the target.
Thomas> * Instead, we should use the headers in $(HOST_DIR)/usr/include. They
Thomas> were not used due to a type: $(HOST_CFLAGS) must be used instead of
Thomas> $(HOSTCFLAGS).
s/type/typo/
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2010-12-21 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 13:14 [Buildroot] [pull request] Pull request for branch for-2011.02/fix-bug-2983 Thomas Petazzoni
2010-12-21 13:14 ` [Buildroot] [PATCH 1/1] xlib_libX11: compile makekeys for the host correctly Thomas Petazzoni
2010-12-21 13:20 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5dbuush.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox