Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Stefan Ott via buildroot <buildroot@buildroot.org>
Cc: Stefan Ott <stefan@ott.net>,  Bernd Kuhls <bernd@kuhls.net>
Subject: Re: [Buildroot] [PATCH 1/1] package/libcec: Add option to use kernel framework
Date: Sat, 10 Oct 2026 22:15:42 +0200	[thread overview]
Message-ID: <87se2d9us1.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20260629020636.4066911-1-stefan@ott.net> (Stefan Ott via buildroot's message of "Mon, 29 Jun 2026 04:06:36 +0200")

>>>>> "Stefan" == Stefan Ott via buildroot <buildroot@buildroot.org> writes:

Hi,

 > As explained in libcec's README.raspberrypi.md:
 >   On a recent Raspberry Pi that's using the vc4_kms_3d dtoverlay,
 >   you have to use the Linux Kernel driver and disable the Raspberry Pi
 >   driver with -DHAVE_RPI_API=0 to use CEC.

 > This patch adds an option to do just that to the libcec package.

..

 > +ifeq ($(BR2_PACKAGE_LIBCEC_LINUX_API),y)
 > +LIBCEC_CONF_OPTS += \
 > +	-DHAVE_RPI_API=0 \
 > +	-DHAVE_LINUX_API=1

HAVE_RPI_API defaults to off, so no need to explicitly set it 0. The
Linux API needs the linux/cec.h header which was added in 4.10, so we
need a dependency on >= 4.10 headers.

The Linux API support only adds around ~3% to the build size, so I
think it makes most sense to automatically enable it if the kernel
headers are new enough rather than an option:

-rwxr-xr-x 1 peko peko 594K Oct 10 18:53 target/usr/lib/libcec.so.8.1.7.without
-rwxr-xr-x 1 peko peko 614K Oct 10 18:53 target/usr/lib/libcec.so.8.1.7.with

Committed with that changed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-10-10 20:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  2:06 [Buildroot] [PATCH 1/1] package/libcec: Add option to use kernel framework Stefan Ott via buildroot
2026-10-10 20:15 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se2d9us1.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=bernd@kuhls.net \
    --cc=buildroot@buildroot.org \
    --cc=stefan@ott.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox