Re: [Buildroot] [PATCH 1/1] package/x265: bump version to 4.2

From: Peter Korsgaard <peter@korsgaard.com>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org,  Thijs Vermeir <thijsvermeir@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/x265: bump version to 4.2
Date: Sat, 10 Oct 2026 14:46:35 +0200	[thread overview]
Message-ID: <87se2du3is.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20260619142831.3664440-1-bernd@kuhls.net> (Bernd Kuhls's message of "Fri, 19 Jun 2026 16:28:31 +0200")

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > https://mailman.videolan.org/pipermail/x265-devel/2026-April/014533.html
 > Rebased patch 0001.
 > Removed remaining patches which are included in this release.

 > Added dependency to _SYNC_8 for cli due to upstream commit
 > https://bitbucket.org/multicoreware/x265_git/commits/7ea54bdf5a6a35e3fff44d8454e31695928dc752#Lsource/common/threading.hT70

This points to the #if NO_ATOMICS conditional, so you probably instead
mean:

https://bitbucket.org/multicoreware/x265_git/commits/7ea54bdf5a6a35e3fff44d8454e31695928dc752#Lsource/common/threading.hT88

As there is a NO_ATOMICS logic, perhaps we should just pass
-DNO_ATOMICS=ON if !BR2_TOOLCHAIN_HAS_SYNC_8? In any case, it is not
specific to the CLI, but should be for the x265 package instead (the
dependency on __sync_fetch_and_add_8 comes from the library, not the
cli).

 > This bump includes upstream commit
 > https://bitbucket.org/multicoreware/x265_git/commits/f74b2f38ad850a09524f331f64870e6300fd923b
 > that uses vst1q_s16_x2() which was first added to gcc 9:
 > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=568421baa5a4cdb7bb7c5ac323c939492ee3f052

 > causing build errors detected by the Gitlab pipelines:
 > /builds/bkuhls/buildroot/br-test-pkg/bootlin-aarch64-glibc-old/build/x265-4.2/source/common/aarch64/pixel-prim.cpp:936:25:
 >  error: ‘vst1q_s16_x2’ was not declared in this scope

 > Disable asm for i386 with musl toolchains to fix linking error detected
 > by the Gitlab pipelines:

 > /builds/bkuhls/buildroot/br-test-pkg/bootlin-x86-i686-musl/build/x265-4.2/source/common/x86/cpu-a.asm:181:
 >  error: ELF format cannot produce non-PC-relative PLT references

It sounds odd to me that the C library would matter for an error
generated for nasm. I did a test build with i686/glibc and see the same
issue:

[ 13%] Building ASM_NASM object common/CMakeFiles/common.dir/x86/mc-a.asm.o
/home/peko/source/buildroot/output-x265b/build/x265-4.2/source/common/x86/cpu-a.asm:181: error: ELF format cannot produce non-PC-relative PLT references

Looking upstream, I see there is a 4.3 release which among bugfixes
lists:

Fix i686 build failure (non-PC-relative PLT references) and PowerPC64
build with Clang.

So maybe worth bumping to that instead?

Care to fix that and resend?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot