Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: buildroot@buildroot.org,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/ugetty: support building "proxycommand" binary for host
Date: Wed, 29 Apr 2026 19:39:31 +0200	[thread overview]
Message-ID: <87se8dhdik.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20260429093339.3232096-1-fiona.klute@gmx.de> (Fiona Klute's message of "Wed, 29 Apr 2026 11:33:39 +0200")

>>>>> "Fiona" == Fiona Klute <fiona.klute@gmx.de> writes:

 > The "proxycommand" binary is used with SSH clients to connect to
 > ugetty over serial. Building it as a host package makes it easy to use
 > with Buildroot builds including ugetty on the target, without needing
 > a separate install.

 > Signed-off-by: Fiona Klute <fiona.klute@gmx.de>

..

 > diff --git a/package/ugetty/ugetty.mk b/package/ugetty/ugetty.mk
 > index 0e306a02c2..d8e8c85918 100644
 > --- a/package/ugetty/ugetty.mk
 > +++ b/package/ugetty/ugetty.mk
 > @@ -20,4 +20,14 @@ define UGETTY_INSTALL_TARGET_CMDS
 >  	ln -snf ugetty $(TARGET_DIR)/sbin/getty
 >  endef
 
 > +define HOST_UGETTY_BUILD_CMDS
 > +	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) bin/proxycommand
 > +endef
 > +
 > +define HOST_UGETTY_INSTALL_CMDS
 > +	$(INSTALL) -m 0755 $(@D)/bin/proxycommand \
 > +		$(HOST_DIR)/bin/proxycommand

It is handy to use install -D so the directory is created if not yet
present, so I changed that.

I see that I also forgot to do so for the target install, so I will send
a separate patch for that.

Committed with that changed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-04-29 17:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  9:33 [Buildroot] [PATCH 1/1] package/ugetty: support building "proxycommand" binary for host Fiona Klute via buildroot
2026-04-29 17:39 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se8dhdik.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=fiona.klute@gmx.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox