public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: <yann.morin@orange.com>
Cc: buildroot@buildroot.org,
	"Titouan Christophe" <titouan.christophe@mind.be>,
	"Vincent Stehlé" <vincent.stehle@arm.com>,
	"Joseph Kogut" <joseph.kogut@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/mosquitto: disable building the crtl-shell for host variant
Date: Wed, 01 Apr 2026 11:27:39 +0200	[thread overview]
Message-ID: <87se9f58tw.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <7b86fd0c400abfa616573d98d996c3a32cf87135.1775020521.git.yann.morin@orange.com> (yann morin's message of "Wed, 1 Apr 2026 07:15:21 +0200")

>>>>>   <yann.morin@orange.com> writes:

 > From: "Yann E. MORIN" <yann.morin@orange.com>
 > The ctrl-shell, in mosquitto_ctrl, optionally uses a line-editing
 > library, either libedit or readline. There is a single option (in
 > mosquitto) that drives whether to build all the aopps or none, but
 > for the host variant, we're only interested in mosquitto_passwd,
 > not mosquitto_ctrl (nor the others either).

 > Explicitly disable the ctrl-shell, to avoid build failures when the
 > host has a mixed installation of readline or libedit that is not
 > compatible with ours.

 > Fixes:
 >     https://autobuild.buildroot.org/results/856/856352ddd690dc8b2314d46a6a837d74c237d69f

 > Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > Cc: Titouan Christophe <titouan.christophe@mind.be>
 > Cc: Vincent Stehlé <vincent.stehle@arm.com>
 > Cc: Joseph Kogut <joseph.kogut@gmail.com>

 > ---
 > Note: I was not able to reproduce the issue locally, so I am not certain
 > of the fix. Vincent, Joseph, if you could test in your autobuilders (or
 > provide the `dpkg --get-selections` or similar for Arch...)

There isn't really any use case for having a host version of it, so
committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-04-01  9:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01  5:15 [Buildroot] [PATCH] package/mosquitto: disable building the crtl-shell for host variant yann.morin
2026-04-01  9:27 ` Peter Korsgaard [this message]
2026-04-10 10:26 ` Thomas Perale via buildroot
2026-04-10 10:57   ` yann.morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se9f58tw.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=joseph.kogut@gmail.com \
    --cc=titouan.christophe@mind.be \
    --cc=vincent.stehle@arm.com \
    --cc=yann.morin@orange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox