[Buildroot] [PATCH] package/mosquitto: disable building the crtl-shell for host variant

[Buildroot] [PATCH] package/mosquitto: disable building the crtl-shell for host variant

[yann.morin]

From: "Yann E. MORIN" <yann.morin@orange.com>

The ctrl-shell, in mosquitto_ctrl, optionally uses a line-editing
library, either libedit or readline. There is a single option (in
mosquitto) that drives whether to build all the aopps or none, but
for the host variant, we're only interested in mosquitto_passwd,
not mosquitto_ctrl (nor the others either).

Explicitly disable the ctrl-shell, to avoid build failures when the
host has a mixed installation of readline or libedit that is not
compatible with ours.

Fixes:
    https://autobuild.buildroot.org/results/856/856352ddd690dc8b2314d46a6a837d74c237d69f

Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Titouan Christophe <titouan.christophe@mind.be>
Cc: Vincent Stehlé <vincent.stehle@arm.com>
Cc: Joseph Kogut <joseph.kogut@gmail.com>

---
Note: I was not able to reproduce the issue locally, so I am not certain
of the fix. Vincent, Joseph, if you could test in your autobuilders (or
provide the `dpkg --get-selections` or similar for Arch...)
---
 package/mosquitto/mosquitto.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/mosquitto/mosquitto.mk b/package/mosquitto/mosquitto.mk
index 06de7fc2af..6d68fa4773 100644
--- a/package/mosquitto/mosquitto.mk
+++ b/package/mosquitto/mosquitto.mk
@@ -158,6 +158,7 @@ HOST_MOSQUITTO_CONF_OPTS = \
 	-DWITH_PLUGINS=OFF \
 	-DWITH_TESTS=OFF \
 	-DWITH_APPS=ON \
+	-DWITH_CTRL_SHELL=OFF \
 	-DWITH_TLS=ON
 
 # Manually install just the one tool we need
-- 
2.34.1

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/mosquitto: disable building the crtl-shell for host variant

[Peter Korsgaard]

>>>>>   <yann.morin@orange.com> writes:

 > From: "Yann E. MORIN" <yann.morin@orange.com>
 > The ctrl-shell, in mosquitto_ctrl, optionally uses a line-editing
 > library, either libedit or readline. There is a single option (in
 > mosquitto) that drives whether to build all the aopps or none, but
 > for the host variant, we're only interested in mosquitto_passwd,
 > not mosquitto_ctrl (nor the others either).

 > Explicitly disable the ctrl-shell, to avoid build failures when the
 > host has a mixed installation of readline or libedit that is not
 > compatible with ours.

 > Fixes:
 >     https://autobuild.buildroot.org/results/856/856352ddd690dc8b2314d46a6a837d74c237d69f

 > Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > Cc: Titouan Christophe <titouan.christophe@mind.be>
 > Cc: Vincent Stehlé <vincent.stehle@arm.com>
 > Cc: Joseph Kogut <joseph.kogut@gmail.com>

 > ---
 > Note: I was not able to reproduce the issue locally, so I am not certain
 > of the fix. Vincent, Joseph, if you could test in your autobuilders (or
 > provide the `dpkg --get-selections` or similar for Arch...)

There isn't really any use case for having a host version of it, so
committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/mosquitto: disable building the crtl-shell for host variant

[Thomas Perale via buildroot]

Hi Yann,

In reply of:
> The ctrl-shell, in mosquitto_ctrl, optionally uses a line-editing
> library, either libedit or readline. There is a single option (in
> mosquitto) that drives whether to build all the aopps or none, but
> for the host variant, we're only interested in mosquitto_passwd,
> not mosquitto_ctrl (nor the others either).
> 
> Explicitly disable the ctrl-shell, to avoid build failures when the
> host has a mixed installation of readline or libedit that is not
> compatible with ours.
> 
> Fixes:
>     https://autobuild.buildroot.org/results/856/856352ddd690dc8b2314d46a6a837d74c237d69f
> 
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Cc: Titouan Christophe <titouan.christophe@mind.be>
> Cc: Vincent Stehlé <vincent.stehle@arm.com>
> Cc: Joseph Kogut <joseph.kogut@gmail.com>
> 
> ---
> Note: I was not able to reproduce the issue locally, so I am not certain
> of the fix. Vincent, Joseph, if you could test in your autobuilders (or
> provide the `dpkg --get-selections` or similar for Arch...)
> ---

To double check, does a backport to 2025.02.x needs to be done or it's a result
of the recent version bump ?

Thanks,
Best regards,
PERALE Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/mosquitto: disable building the crtl-shell for host variant

[yann.morin]

Thomas, All,

On 2026-04-10 12:26 +0200, Thomas Perale spake thusly:
> In reply of:
[--SNIP--]
> > Explicitly disable the ctrl-shell, to avoid build failures when the
> > host has a mixed installation of readline or libedit that is not
> > compatible with ours.
[--SNIP--]
> To double check, does a backport to 2025.02.x needs to be done or it's a result
> of the recent version bump ?

The control-shell is not present in mosquitoo 2.0.x, which is what is
packaged in the maintenance branches of Buildroot.

So, there is no need for a backport.

Thanks!

Regards,
Yann E. MORIN.

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
|                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
| yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot