Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/wcurl: new package
Date: Thu, 21 Aug 2025 20:08:42 +0300	[thread overview]
Message-ID: <87sehkzjol.fsf@tarshish> (raw)
In-Reply-To: <20250821164828.3540002-1-angelo.compagnucci@gmail.com> (Angelo Compagnucci's message of "Thu, 21 Aug 2025 18:48:28 +0200")

Hi Angelo,

On Thu, Aug 21 2025, Angelo Compagnucci wrote:
> wcurl is a command line tool which lets you download URLs without having to
> remember any parameters.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---

[...]

> diff --git a/package/wcurl/Config.in b/package/wcurl/Config.in
> new file mode 100644
> index 0000000000..da7a3922f5
> --- /dev/null
> +++ b/package/wcurl/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_WCURL
> +	bool "wcurl"
> +	depends on BR2_PACKAGE_LIBCURL_CURL

I think this is better:

  select BR2_PACKAGE_LIBCURL
  select BR2_PACKAGE_LIBCURL_CURL

The need to enable BR2_PACKAGE_LIBCURL_CURL to expose wcurl package in
the menu is not entirely obvious, IMO.

> +	help
> +	  wcurl is a small command-line tool that wraps curl for easier use
> +	  when downloading files from the web.
> +
> +	  https://curl.se/wcurl/
> diff --git a/package/wcurl/wcurl.hash b/package/wcurl/wcurl.hash
> new file mode 100644
> index 0000000000..b747e99502
> --- /dev/null
> +++ b/package/wcurl/wcurl.hash
> @@ -0,0 +1,3 @@
> +# sha256 locally computed
> +sha256  a745475f3511090685c4d000a10f4155147b75a8c7781764612a7e8f67bb6d82  wcurl-2025.05.26.tar.gz
> +sha256  0127bdd267b1fa65bf5a6c487c907948e0c009aa35a5949c8aed91f779d27810  LICENSE
> diff --git a/package/wcurl/wcurl.mk b/package/wcurl/wcurl.mk
> new file mode 100644
> index 0000000000..98d15a1a6b
> --- /dev/null
> +++ b/package/wcurl/wcurl.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# wcurl
> +#
> +################################################################################
> +
> +WCURL_VERSION = 2025.05.26
> +WCURL_SITE = $(call github,curl,wcurl,v$(WCURL_VERSION))
> +WCURL_LICENSE = curl
> +WCURL_LICENSE_FILES = LICENSE
> +WCURL_DEPENDENCIES = libcurl

Are you sure libcurl is needed a build time?

> +
> +define FOO_INSTALL_TARGET_CMDS
> +	 $(INSTALL) -D -m 0755 $(@D)/wcurl $(TARGET_DIR)/usr/bin
> +endef
> +
> +$(eval $(generic-package))

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2025-08-21 17:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 16:48 [Buildroot] [PATCH] package/wcurl: new package Angelo Compagnucci
2025-08-21 17:08 ` Baruch Siach via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sehkzjol.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=angelo.compagnucci@gmail.com \
    --cc=baruch@tkos.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox