From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99270CE7A88 for ; Sun, 24 Sep 2023 16:06:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2B45D416A2; Sun, 24 Sep 2023 16:06:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2B45D416A2 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wjRcAtBCiI-F; Sun, 24 Sep 2023 16:06:25 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 43AFA41621; Sun, 24 Sep 2023 16:06:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 43AFA41621 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id D11271BF3BB for ; Sun, 24 Sep 2023 16:06:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AA64181AD1 for ; Sun, 24 Sep 2023 16:06:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AA64181AD1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TOBatIkmRXp2 for ; Sun, 24 Sep 2023 16:06:17 +0000 (UTC) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by smtp1.osuosl.org (Postfix) with ESMTPS id 5300481ADE for ; Sun, 24 Sep 2023 16:06:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5300481ADE Received: by mail.gandi.net (Postfix) with ESMTPSA id 6B47C20002; Sun, 24 Sep 2023 16:06:13 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1qkRcK-000B36-75; Sun, 24 Sep 2023 18:05:56 +0200 From: Peter Korsgaard To: "Yann E. MORIN" References: <37efd0eb722d848b20c769d4273af70997c87b33.1694556946.git.yann.morin.1998@free.fr> Date: Sun, 24 Sep 2023 18:05:56 +0200 In-Reply-To: <37efd0eb722d848b20c769d4273af70997c87b33.1694556946.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Wed, 13 Sep 2023 00:15:51 +0200") Message-ID: <87sf73k13v.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-GND-Sasl: peter@korsgaard.com Subject: Re: [Buildroot] [PATCH 4/5] support/download/git: fix shellcheck errors X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Yann" == Yann E MORIN writes: > The quoting around the expansion of ${relative_dir} was indeed incorrect > since it was introduced back in 8fe9894f655f (suport/download: fix git > wrapper with submodules on older git versions): it is in fact already > quoted as part of the whole sed expression. > ${GIT} can contain more than one item, but we don't care about splitting > on spaces when we just print it for debug, so we can just quote it > rather than add an exception. > Signed-off-by: Yann E. MORIN Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot