From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 2/3] package/socat: disable openssl for static build
Date: Wed, 02 Nov 2022 06:43:09 +0200 [thread overview]
Message-ID: <87sfj2otch.fsf@tarshish> (raw)
In-Reply-To: <20221101215836.44ee15cd@windsurf>
Hi Thomas,
On Tue, Nov 01 2022, Thomas Petazzoni wrote:
> On Tue, 01 Nov 2022 22:47:10 +0200
> Baruch Siach <baruch@tkos.co.il> wrote:
>
>> > SOCAT_CONF_ENV += LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
>> >
>> > does not work?
>>
>> It does not work because configure.ac puts $LIBS before -lssl in the
>> tested command line.
>
> ACK.
>
>> > Also, do you have an autobuilder failure for this issue? Or you just
>> > encountered it locally?
>>
>> We don't pass an explicit --with-openssl because socan configure does
>> not support it. So the configure script just behaves as if openssl is
>> not there, which is normal.
>
> Hm, OK, but that does not really answer my question :-)
There is no build failure so the autobuilders can't catch it. So yes, I
have seen the issue in local build tests of static linking.
This patch does not actually change the current behavior. Statically
linked socan lacks OpenSSL support either way. But this patch makes it
explicit.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-02 4:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 7:41 [Buildroot] [PATCH 1/3] package/socat: fix printf feature detection Baruch Siach via buildroot
2022-11-01 7:41 ` [Buildroot] [PATCH 2/3] package/socat: disable openssl for static build Baruch Siach via buildroot
2022-11-01 20:32 ` Thomas Petazzoni via buildroot
2022-11-01 20:47 ` Baruch Siach via buildroot
2022-11-01 20:58 ` Thomas Petazzoni via buildroot
2022-11-02 4:43 ` Baruch Siach via buildroot [this message]
2022-11-05 22:49 ` Thomas Petazzoni via buildroot
2022-11-14 19:38 ` Peter Korsgaard
2022-11-01 7:41 ` [Buildroot] [PATCH 3/3] package/socat: bump to version 1.7.4.4 Baruch Siach via buildroot
2022-11-05 22:50 ` Thomas Petazzoni via buildroot
2022-11-01 20:29 ` [Buildroot] [PATCH 1/3] package/socat: fix printf feature detection Thomas Petazzoni via buildroot
2022-11-01 20:43 ` Baruch Siach via buildroot
2022-11-05 22:49 ` Thomas Petazzoni via buildroot
2022-11-14 19:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfj2otch.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox