Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Nicola Di Lieto <nicola.dilieto@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCHv5] package/uacme: requires TLS support in libcurl
Date: Thu, 11 Aug 2022 13:06:17 +0200	[thread overview]
Message-ID: <87sfm3m446.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220718203847.2646609-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Mon, 18 Jul 2022 22:38:47 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: Baruch Siach <baruch@tkos.co.il>
 > uacme configure script fails when libcurl does not support TLS. This
 > means that BR2_PACKAGE_LIBCURL_TLS_NONE is incompatible with uacme.

 > Add a kconfig knob to libcurl, BR2_PACKAGE_LIBCURL_FORCE_TLS, so that
 > _TLS_NONE is not an option. Select that from uacme.

 > Note that, beside selecting BR2_PACKAGE_LIBCURL_FORCE_TLS, packages will
 > have to also select a package that can be used as a crypto backend by
 > libcurl. Use of BR2_PACKAGE_LIBCURL_FORCE_TLS is unlikely to become very
 > common in the foreseeable future, so we don't need to optimize for this
 > corner case.

 > uacme already needs a crypto package for itself, so the above
 > requirement is naturally met for uacme.

 > Fixes:
 > http://autobuild.buildroot.net/results/4e16f1d958ac3d30e26e7f17bdffc47834b0e2bd/
 > http://autobuild.buildroot.net/results/4e16f1d958ac3d30e26e7f17bdffc47834b0e2bd/
 > http://autobuild.buildroot.net/results/25280409b32282b4dd40b1e88127051439380f3d/

 > Cc: Nicola Di Lieto <nicola.dilieto@gmail.com>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
 > [yann.morin.1998@free.fr:
 >   - keep the current forward select
 >   - add the kconfig knob
 > ]
 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

 > ---
 > v5 (Yann E. MORIN):
 >   Rename knob to _FORCE_TLS (Baruch)
 >   _FORCE_TLS needs a crypto package to be selected (Baruch)
 >   Expand commit log to explain that (Baruch)

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-08-11 11:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 20:38 [Buildroot] [PATCHv5] package/uacme: requires TLS support in libcurl Yann E. MORIN
2022-07-19  3:29 ` Baruch Siach via buildroot
2022-07-19 15:48   ` Yann E. MORIN
2022-08-11 11:06 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfm3m446.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=nicola.dilieto@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox