Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/pkg-python: use _CONFIGURE_OPTS for build env
Date: Sat, 07 Dec 2019 14:07:41 +0100	[thread overview]
Message-ID: <87sglwl1wi.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20191206233513.5f6260d7@windsurf.home> (Thomas Petazzoni's message of "Fri, 6 Dec 2019 23:35:13 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Thu,  5 Dec 2019 17:11:02 -0600
 > Ryan Barnett <ryan.barnett@rockwellcollins.com> wrote:

 >> When building host or target python packages, we need to ensure that
 >> the build environment utilize {HOST|TARGET}_CONFIGURE_OPTS. This
 >> ensures that the correct linker and compiler environment variables are
 >> set to compile utilizing either the host or target folders.
 >> 
 >> It was discovered that when compiling a host-python package, it was
 >> using linking against the build machines library folder instead of the
 >> host folder because LDFLAGS was not properly set and was improperly
 >> detecting whether or not a shared or static library was present in the
 >> host folder.
 >> 
 >> CC: Arnout Vandecappelle <arnout@mind.be>
 >> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
 >> 
 >> ---
 >> Changes v1 -> v2:
 >> - Merged HOST/TARGET_CONFIGURE_OPTS to single commit (suggested by
 >> Arnout)
 >> - Added HOST/TARGET_CONFIGURE_OPTS to env for setuptools (suggested
 >> by Arnout)
 >> ---
 >> package/pkg-python.mk | 11 ++++++-----
 >> 1 file changed, 6 insertions(+), 5 deletions(-)

 > Applied to master, thanks.

Hmm, this seems to confuse lirc-tools:

http://autobuild.buildroot.net/results/f7a/f7a9c02add9bde563c7289f7c0be2cb7aefd96b8/build-end.log

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2019-12-07 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 23:11 [Buildroot] [PATCH] package/pkg-python: use _CONFIGURE_OPTS for build env Ryan Barnett
2019-12-06 22:35 ` Thomas Petazzoni
2019-12-07 13:07   ` Peter Korsgaard [this message]
2019-12-09 15:53     ` Thomas Petazzoni
2019-12-09 16:23       ` Ryan Barnett
2019-12-22 20:31 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sglwl1wi.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox