Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pkg-infra/show-info: dump install_{staging, target} info
Date: Wed, 07 Aug 2019 09:18:25 +0200	[thread overview]
Message-ID: <87sgqdmoji.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190723144459.5bfcc0fd@windsurf> (Thomas Petazzoni's message of "Tue, 23 Jul 2019 14:44:59 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Tue, 23 Jul 2019 15:33:55 +0300
 > Vadim Kochan <vadim4j@gmail.com> wrote:

 >> provide info if the package will be installed to staging/target
 >> destinations. Might be useful for analyzing the packages which
 >> installed only for target/staging.
 >> 
 >> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
 >> ---
 >> package/pkg-utils.mk | 8 ++++++++
 >> 1 file changed, 8 insertions(+)
 >> 
 >> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
 >> index b7280e930f..81222565bf 100644
 >> --- a/package/pkg-utils.mk
 >> +++ b/package/pkg-utils.mk
 >> @@ -94,6 +94,14 @@ endef
 >> define _json-info-pkg-details
 >> "version": "$($(1)_DL_VERSION)",
 >> "licenses": "$($(1)_LICENSE)",
 >> +	$(if $($(1)_INSTALL_TARGET), \
 >> +		"install_target": true$(comma),
 >> +		"install_target": false$(comma)
 >> +	)
 >> +	$(if $($(1)_INSTALL_STAGING), \
 >> +		"install_staging": true$(comma),
 >> +		"install_staging": false$(comma)
 >> +	)

 > I would prefer install-target and install-staging for the JSON property
 > names, I prefer - over _.

Notice that some programming languages handle json like variables
(object.property.subproperty), and '-' is typically not allowed in
variable names.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2019-08-07  7:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 12:33 [Buildroot] [PATCH 1/1] pkg-infra/show-info: dump install_{staging, target} info Vadim Kochan
2019-07-23 12:44 ` Thomas Petazzoni
2019-07-28  9:56   ` Yann E. MORIN
2019-07-28 10:01     ` Yann E. MORIN
2019-08-07  7:18   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgqdmoji.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox