Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake
Date: Thu, 24 Jan 2019 16:50:53 +0100	[thread overview]
Message-ID: <87sgxidpgi.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190112160727.43c0f7c0@windsurf.home> (Thomas Petazzoni's message of "Sat, 12 Jan 2019 16:07:27 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello,
 > On Fri, 11 Jan 2019 00:05:28 +0100, Arnout Vandecappelle
 > (Essensium/Mind) wrote:
 >> Quoting the CMake documentation:
 >> 
 >> When the CMAKE_SYSTEM_NAME variable is set explicitly to enable cross
 >> compiling then the value of CMAKE_SYSTEM_VERSION must also be set
 >> explicitly to specify the target system version.
 >> 
 >> Thus, we should also set CMAKE_SYSTEM_VERSION in toolchainfile.cmake. It
 >> is supposed to be set to the value of `uname -r` on the target. We don't
 >> have that exact value available (unless we build the kernel), but the
 >> value of BR2_TOOLCHAIN_HEADERS_AT_LEAST contains the (minimum) version
 >> of the kernel it will run on, so it should be OK for all practical
 >> purposes.
 >> 
 >> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 >> Cc: Samuel Martin <s.martin49@gmail.com>
 >> ---
 >> package/pkg-cmake.mk                | 1 +
 >> support/misc/toolchainfile.cmake.in | 1 +
 >> 2 files changed, 2 insertions(+)

Committed to 2018.02.x and 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2019-01-24 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 23:05 [Buildroot] [PATCH 1/2] pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake Arnout Vandecappelle
2019-01-10 23:05 ` [Buildroot] [PATCH 2/2] azure-iot-sdk-c: remove dummy value of CMAKE_SYSTEM_VERSION Arnout Vandecappelle
2019-01-11 21:16 ` [Buildroot] [PATCH 1/2] pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake Yann E. MORIN
2019-01-12 15:06   ` Thomas Petazzoni
2019-01-12 15:23     ` Yann E. MORIN
2019-01-12 16:07       ` Thomas Petazzoni
2019-01-12 15:07 ` Thomas Petazzoni
2019-01-12 15:26   ` Yann E. MORIN
2019-01-24 15:50   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgxidpgi.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox