From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] website: footer.html: use 1.7.1 release of clipboard.js
Date: Sat, 28 Apr 2018 09:31:41 +0200 [thread overview]
Message-ID: <87sh7fyeg2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180427195017.18344-1-peter@korsgaard.com> (Peter Korsgaard's message of "Fri, 27 Apr 2018 21:50:16 +0200")
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> The clipboard javascript code causes an error:
> Uncaught TypeError: Illegal constructor
> at buildroot.js:58
> Which is caused by a recent change in upstream clipboard.js:
> https://github.com/zenorocha/clipboard.js/releases/tag/v2.0.0
> Changes constructor from new Clipboard() to new ClipboardJS()
> The issue was that we were using the master version of clipboard.js instead
> of a specific release. Fix it by using the 1.7.1 version (latest release
> before the constructor change) instead.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-04-28 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 19:50 [Buildroot] [PATCH 1/2] website: footer.html: use 1.7.1 release of clipboard.js Peter Korsgaard
2018-04-27 19:50 ` [Buildroot] [PATCH 2/2] docs/website: add favicon.png Peter Korsgaard
2018-04-28 7:31 ` Peter Korsgaard
2018-04-28 7:31 ` Peter Korsgaard [this message]
2018-04-28 8:44 ` [Buildroot] [PATCH 1/2] website: footer.html: use 1.7.1 release of clipboard.js Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh7fyeg2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox