From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 15/15 v4] fs: remove intermediate artefacts
Date: Sat, 31 Mar 2018 19:53:36 +0200 [thread overview]
Message-ID: <87sh8gt9lr.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <aa32fec260607f3c9e3a436873b8ef72802078e7.1522487149.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sat, 31 Mar 2018 11:06:01 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Each of the intermediate, per-rootfs target directories, as well as the
> intermediate tarball, can take quite some place, and is mostly a
> duplication of what's already in target/. The only delta, if any, would
> be the tweaks made by the filesystem image generations, but those tweaks
> are most probably only meaningfull when seen as root.
> We normally do not remove intermediate files, but those can be quite
> large, and are not directly usable by, nor accessible to the user.
> So, get rid of them once the filesystem has been generated.
> This does not need to be done in fakeroot.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Tested-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
> Makefile | 1 +
> fs/common.mk | 2 ++
> 2 files changed, 3 insertions(+)
> diff --git a/Makefile b/Makefile
> index 9fba7a3ed8..96c2d200a3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -756,6 +756,7 @@ endif
> .PHONY: target-post-image
> target-post-image: $(TARGETS_ROOTFS) target-finalize
> + @rm -f $(ROOTFS_COMMON_TAR)
> @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \
> $(call MESSAGE,"Executing post-image script $(s)"); \
> $(EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep))
> diff --git a/fs/common.mk b/fs/common.mk
> index bacc98ec68..2ee130ee08 100644
> --- a/fs/common.mk
> +++ b/fs/common.mk
> @@ -96,6 +96,7 @@ endif
> $(call PRINTF,$(ROOTFS_COMMON_TAR_CMD)) >> $(FAKEROOT_SCRIPT)
> chmod a+x $(FAKEROOT_SCRIPT)
> PATH=$(BR_PATH) $(HOST_DIR)/bin/fakeroot -- $(FAKEROOT_SCRIPT)
> + $(Q)rm -rf $(TARGET_DIR)
This throws away the output/target copy on each invocation, so there is
not much sense in using rsync to create it and we could just use cp -a,
but OK, that can be done later.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-03-31 17:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 9:05 [Buildroot] [PATCH 00/15 v4] fs: support parallel filesystems build Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 01/15 v4] fs: run filesystem hooks under fakeroot Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 02/15 v4] fs/cpio: don't extend packages' permissions table Yann E. MORIN
2018-03-31 17:43 ` Peter Korsgaard
2018-03-31 9:05 ` [Buildroot] [PATCH 03/15 v4] fs/iso9660: rename internal variable Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 04/15 v4] core: introduce intermediate BASE_TARGET_DIR variable Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 05/15 v4] fs: set per-rootfs variable name Yann E. MORIN
2018-03-31 18:28 ` Arnout Vandecappelle
2018-03-31 9:05 ` [Buildroot] [PATCH 06/15 v4] fs: define per-rootfs directory Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 07/15 v4] fs: use a per-rootfs fakeroot script Yann E. MORIN
2018-03-31 17:50 ` Peter Korsgaard
2018-03-31 18:26 ` Arnout Vandecappelle
2018-03-31 18:43 ` Arnout Vandecappelle
2018-03-31 9:05 ` [Buildroot] [PATCH 08/15 v4] fs: split per-rootfs dependency line Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 09/15 v4] fs: introduce per-rootfs TARGET_DIR variable Yann E. MORIN
2018-03-31 18:30 ` Arnout Vandecappelle
2018-03-31 18:51 ` Yann E. MORIN
2018-03-31 18:57 ` Arnout Vandecappelle
2018-03-31 19:11 ` Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 10/15 v4] fs: new intermediate rootfs-common to gather common dependencies Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 11/15 v4] fs: introduce a macro for reproducible command Yann E. MORIN
2018-03-31 9:05 ` [Buildroot] [PATCH 12/15 v4] fs: use a common tarball as base for the other filesystems Yann E. MORIN
2018-03-31 18:53 ` Arnout Vandecappelle
2018-03-31 9:05 ` [Buildroot] [PATCH 13/15 v4] fs: run packages' filesystem hooks in a copy of target/ Yann E. MORIN
2018-03-31 19:04 ` Arnout Vandecappelle
2018-03-31 20:27 ` Peter Korsgaard
2018-03-31 21:09 ` Arnout Vandecappelle
2018-04-01 9:54 ` Peter Korsgaard
2018-03-31 9:06 ` [Buildroot] [PATCH 14/15 v4] fs: get rid of package-provided post-fs hooks Yann E. MORIN
2018-03-31 9:06 ` [Buildroot] [PATCH 15/15 v4] fs: remove intermediate artefacts Yann E. MORIN
2018-03-31 17:53 ` Peter Korsgaard [this message]
2018-03-31 18:53 ` [Buildroot] [PATCH 00/15 v4] fs: support parallel filesystems build Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh8gt9lr.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox