Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] support/testing: fix remaining code style
Date: Mon, 02 Oct 2017 16:20:11 +0200	[thread overview]
Message-ID: <87shf1d42s.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <4fe624ec-385e-9f16-88c5-2cf6ca773dd6@mind.be> (Arnout Vandecappelle's message of "Mon, 2 Oct 2017 15:48:51 +0200")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >  For me, the ideal is to wrap at 80 columns most of the time, but allow
 > exceptions up to something like 105 columns. 105 is still reasonable for
 > side-by-side on a wide display with some room for scrollbars. I know, Yann, that
 > you can easily fit 132 characters on side-by-side, but you've got an eagle-eyed
 > font size :-) That said, I can live with 132 as the absolute maximum. However, I
 > do think we should _normally_ wrap at 80 columns.

 >  Standardizing on 80 columns is good because it's what we do in the rest of
 > Buildroot. Allowing exceptions is good because there are some lines you really
 > don't want to split (strings, mostly).

 >  So ideally, I'd like to have a warning for anything about 80 columns, and an
 > error for anything over 105 (or 132). Unfortunately, I don't think flake8 allows
 > that. So let's say we put 132 in the config file, but enforce 80 columns in review.

Agreed! I also think sticking to 80 columns where possible would be good.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2017-10-02 14:20 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29  2:27 [Buildroot] [PATCH 1/5] support/testing: standardize defconfig fragments style Ricardo Martincoski
2017-09-29  2:27 ` [Buildroot] [PATCH 2/5] support/testing: indent ccache defconfig fragment Ricardo Martincoski
2017-09-29  8:17   ` Yann E. MORIN
2017-10-02  1:03     ` Ricardo Martincoski
2017-10-02  5:49       ` Yann E. MORIN
2017-10-02 23:03         ` Ricardo Martincoski
2017-09-29  2:27 ` [Buildroot] [PATCH 3/5] support/testing: fix code style Ricardo Martincoski
2017-09-29  8:21   ` Yann E. MORIN
2017-09-29  2:27 ` [Buildroot] [PATCH 4/5] support/testing: fix remaining " Ricardo Martincoski
2017-09-29  8:04   ` Yann E. MORIN
2017-09-29  8:29     ` Yann E. MORIN
2017-10-02  1:09     ` Ricardo Martincoski
2017-10-02  6:06       ` Yann E. MORIN
2017-10-02 13:48         ` Arnout Vandecappelle
2017-10-02 14:20           ` Peter Korsgaard [this message]
2017-09-29  2:27 ` [Buildroot] [PATCH 5/5] testing/tests/init: use lowercase method names Ricardo Martincoski
2017-09-29  8:23   ` Yann E. MORIN
2017-09-29  8:13 ` [Buildroot] [PATCH 1/5] support/testing: standardize defconfig fragments style Yann E. MORIN
2017-09-29  8:15   ` Yann E. MORIN
2017-10-05 21:42 ` [Buildroot] [PATCH v2 1/6] support/testing: allow to indent ccache defconfig fragment Ricardo Martincoski
2017-10-05 21:42   ` [Buildroot] [PATCH v2 2/6] support/testing: standardize defconfig fragments style Ricardo Martincoski
2017-10-05 21:42   ` [Buildroot] [PATCH v2 3/6] support/testing: fix code style Ricardo Martincoski
2017-10-05 21:42   ` [Buildroot] [PATCH v2 4/6] testing/tests/init: use lowercase method names Ricardo Martincoski
2017-10-06 17:09     ` Arnout Vandecappelle
2017-10-05 21:42   ` [Buildroot] [PATCH v2 5/6] .flake8: add config file for Python code style Ricardo Martincoski
2017-10-06 17:10     ` Arnout Vandecappelle
2017-10-05 21:42   ` [Buildroot] [PATCH v2 6/6] support/testing: fix remaining " Ricardo Martincoski
2017-10-06 17:16     ` Arnout Vandecappelle
2017-10-23  2:30       ` Ricardo Martincoski
2017-10-23  8:34         ` Arnout Vandecappelle
2017-10-29  4:03           ` Ricardo Martincoski
2017-10-29 20:20             ` Arnout Vandecappelle
2017-10-06 17:07   ` [Buildroot] [PATCH v2 1/6] support/testing: allow to indent ccache defconfig fragment Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shf1d42s.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox