Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/dropbear: add warning about volatile keys
Date: Sun, 30 Aug 2015 22:05:26 +0200	[thread overview]
Message-ID: <87si70tud5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1440539013-23389-1-git-send-email-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Tue, 25 Aug 2015 23:43:33 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > When the rootfs is read-only, keys will be generated in a volatile
 > location, which is inherently bad as host keys will change on each boot,
 > rendering virtually useless.

+them

 > Add a warning so the user is at least aware of the issue.

 > Consign the rm output to oblivion, to avoid noisy output, now that we
 > have a proper warning.

Is consign a English word? I changed it to 'hide' as I think that is clearer.

 > Move the starting message after the symlink-block, to avoid messages
 > collision. Move the umask as well, sicne /etc/dropbear/ may be world
 > readable; just the private host keys should be ?00 (and dropbear handles
 > that by itself).

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Peter Korsgaard <jacmet@uclibc.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2015-08-30 20:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 21:43 [Buildroot] [PATCH] package/dropbear: add warning about volatile keys Yann E. MORIN
2015-08-30 20:05 ` Peter Korsgaard [this message]
2015-08-30 20:12   ` Yann E. MORIN
2015-08-30 20:14     ` Yann E. MORIN
2015-08-30 21:40     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si70tud5.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox