Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] minidlna: fix static linking
Date: Tue, 28 Jan 2014 22:21:01 +0100	[thread overview]
Message-ID: <87sis72476.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20140128221653.6fc8974b@skate> (Thomas Petazzoni's message of "Tue, 28 Jan 2014 22:16:53 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Dear Peter Korsgaard,
 > On Wed, 8 Jan 2014 09:00:11 +0100, Peter Korsgaard wrote:

 >> -# static build is broken w.r.t libgcc_s
 >> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
 >> +# the configure script / Makefile forgets to link with some of the dependent
 >> +# libraries breaking static linking, so help it along
 >> +MINIDLNA_CONF_ENV = \
 >> +	LIBS='-lavformat -lavcodec -lavutil -logg -lz -lpthread -lm'
 >> +else

 > I know we're doing this in a bunch of cases, but I believe we should
 > rather fix the package itself, rather than encoding into the
 > Buildroot .mk file the list of libraries to link with. Because if
 > libogg or libavutil becomes unnecessary in a future version of
 > minidlna, we may not notice, and still link needlessly against them.

True. Patches are welcome ;)

-- 
Bye, Peter Korsgaard 

  reply	other threads:[~2014-01-28 21:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08  8:00 [Buildroot] [git commit] minidlna: fix static linking Peter Korsgaard
2014-01-28 21:16 ` Thomas Petazzoni
2014-01-28 21:21   ` Peter Korsgaard [this message]
2014-01-28 21:28     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sis72476.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox