Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] busybox: fix link with tirpc
Date: Wed, 21 Nov 2012 11:07:53 +0100	[thread overview]
Message-ID: <87sj83i806.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1353485736-10836-1-git-send-email-arnout@mind.be> (Arnout Vandecappelle's message of "Wed, 21 Nov 2012 09:15:36 +0100")

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> Busybox does partial linking of its modules before linking everything
 Arnout> together into the binary.  Those partial links are done without the
 Arnout> standard libraries, but that also means -ltirpc can't be found.  In
 Arnout> addition, this probably fails horribly with static linking (untested).

 Arnout> The problem is that the LDFLAGS are also used in the partial links.
 Arnout> So instead, use CFLAGS_busybox, which is only used for the busybox
 Arnout> link step.  Also make sure that this is passed through the environment,
 Arnout> not on the command line, so the busybox Makefile can still append to
 Arnout> it.

 Arnout> Fixes e.g.
 Arnout> http://autobuild.buildroot.net/results/e8351e3ba86fdcdb2999548658271a6fde0526a9

Committed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2012-11-21 10:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  8:15 [Buildroot] [PATCH] busybox: fix link with tirpc Arnout Vandecappelle
2012-11-21 10:07 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sj83i806.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox