Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] add ruby serialport extension
Date: Mon, 13 Jul 2009 09:29:34 +0200	[thread overview]
Message-ID: <87skh182ht.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1247141343-8641-1-git-send-email-laurent.laffont@gmail.com> (laurent laffont's message of "Thu\, 9 Jul 2009 14\:09\:03 +0200")

>>>>> "laurent" == laurent laffont <laurent.laffont@gmail.com> writes:

Hi,

 laurent> From: laurent laffont <laurent.laffont@gmail.com>
 laurent> Handle ruby serialport extension cross compilation.
 laurent> http://rubyforge.org/projects/ruby-serialport/

 laurent> Signed-off-by: laurent laffont <laurent.laffont@gmail.com>

 laurent> +++ b/package/ruby-serialport/ruby-serialport-fix-1.9.patch
 laurent> @@ -0,0 +1,52 @@
 laurent> +--- a/ext/impl/posix_serialport.c	2008-12-23 20:35:07.000000000 +0000
 laurent> ++++ b/ext/impl/posix_serialport.c	2009-05-21 16:37:13.000000000 +0100
 laurent> +@@ -38,16 +38,16 @@
 laurent> + static int get_fd_helper(obj)
 laurent> +    VALUE obj;
 laurent> + {
 laurent> +-   OpenFile *fptr;
 laurent> ++   rb_io_t *fptr;


What is this for? It doesn't seem buildroot specific?


 laurent> diff --git a/package/ruby-serialport/ruby-serialport.mk b/package/ruby-serialport/ruby-serialport.mk
 laurent> new file mode 100644
 laurent> index 0000000..797646c
 laurent> --- /dev/null
 laurent> +++ b/package/ruby-serialport/ruby-serialport.mk
 laurent> @@ -0,0 +1,53 @@
 laurent> +#############################################################
 laurent> +#
 laurent> +# ruby-serialport
 laurent> +#
 laurent> +#############################################################
 laurent> +RUBY_SERIALPORT_VERSION = 0.7.0
 laurent> +RUBY_SERIALPORT_SOURCE = ruby-serialport-$(RUBY_SERIALPORT_VERSION).tar.gz
 laurent> +RUBY_SERIALPORT_SITE = http://rubyforge.org/frs/download.php/49992
 laurent> +RUBY_SERIALPORT_DIR:=$(BUILD_DIR)/ruby-serialport-$(RUBY_SERIALPORT_VERSION)
 laurent> +RUBY_SERIALPORT_CAT:=$(ZCAT)
 laurent> +
 laurent> +$(DL_DIR)/$(RUBY_SERIALPORT_SOURCE):
 laurent> +	 $(call DOWNLOAD,$(RUBY_SERIALPORT_SITE,$(RUBY_SERIALPORT_SOURCE))
 laurent> +
 laurent> +ruby-serialport-source: $(DL_DIR)/$(RUBY_SERIALPORT_SOURCE)
 laurent> +
 laurent> +$(RUBY_SERIALPORT_DIR)/.unpacked: $(DL_DIR)/$(RUBY_SERIALPORT_SOURCE)
 laurent> +	$(RUBY_SERIALPORT_CAT) $(DL_DIR)/$(RUBY_SERIALPORT_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
 laurent> +	toolchain/patch-kernel.sh $(RUBY_SERIALPORT_DIR) package/ruby-serialport/ ruby-serialport\*.patch
 laurent> +	touch $@
 laurent> +
 laurent> +$(RUBY_SERIALPORT_DIR)/.configured: $(RUBY_SERIALPORT_DIR)/.unpacked
 laurent> +	(cd $(RUBY_SERIALPORT_DIR)/ext; rm Makefile; \
 laurent> +		RUBYLIB=$(RUBY_DIR):$(RUBY_DIR)/lib:$(RUBY_DIR)/.ext ruby-1.9 -e "require 'mkmf'; create_makefile('serialport')";)


This expects the host to have ruby 1.9 installed. Either we need to
add a check with a sensible error message or you need to compile ruby
for the host in $(HOST_DIR) and use that instead. See libglib2.mk for
an example.


 laurent> +$(RUBY_SERIALPORT_DIR)/.installed: $(RUBY_SERIALPORT_DIR)/ext/serialport.so
 laurent> +	(cd $(RUBY_SERIALPORT_DIR)/ext; \
 laurent> +		$(MAKE) DESTDIR=$(TARGET_DIR) extout=$(RUBY_DIR)/.ext install)

 
Doesn't this need to be stripped?


 laurent> +	touch $@
 laurent> +
 laurent> +ruby-serialport: $(RUBY_SERIALPORT_DIR)/.installed
 laurent> +
 laurent> +ruby-serialport-clean:
 laurent> +	(cd $(RUBY_SERIALPORT_DIR)/ext; \
 laurent> +		$(MAKE) DESTDIR=$(TARGET_DIR) extout=$(RUBY_DIR)/.ext clean)


This will fail if the -source target hasn't executed yet (E.G. running
make clean; make clean) - You can fix it by prefixing the line with
'-' to tell make to ignore errors.


-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-07-13  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 12:09 [Buildroot] [PATCH] add ruby serialport extension laurent.laffont at gmail.com
2009-07-13  7:29 ` Peter Korsgaard [this message]
     [not found]   ` <4a339d7c0907130123u64b93c08h3c3f3a850188b1ec@mail.gmail.com>
2009-07-13  8:27     ` laurent laffont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87skh182ht.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox